Repository navigation
Conversation
bhimrazy
requested review from
Abdul-0x4A,
andyland,
dmitsf and
tchaton
as code owners
October 5, 2026 09:20
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
===================================
- Coverage 85% 85% -0%
===================================
Files 40 40
Lines 3299 3299
===================================
- Hits 2797 2796 -1
- Misses 502 503 +1 🚀 New features to boost your workflow:
|
… 3.10 wheels The oldest-requirements CI leg pins pyzmq to its declared minimum. pyzmq 22.0.0 ships no wheels for Python 3.10+, so it is built from source, and its bundled libzmq fails to compile against GCC 13's libstdc++ on ubuntu-24.04 (static assertion in allocator_traits for secure_allocator_t). 22.2.1 is the first pyzmq release with cp310 wheels for Linux, macOS and Windows, so it is the lowest version installable on LitServe's minimum supported Python without a compiler.
bhimrazy
requested review from
ethanwharris,
justusschock and
k223kim
as code owners
October 5, 2026 15:45
Collaborator
Author
|
Closing in favor of a stacked PR series; the new PRs will be linked here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the remaining floating and retiring runner labels to pinned images, and aligns everything on
ubuntu-24.04,macos-26,windows-2025(ci-testing.ymlalready hadwindows-2025).ci-checks.yml:ubuntu-latest/macos-latest/windows-latest→ubuntu-24.04/macos-26/windows-2025ci-testing.yml:macos-15→macos-26, and the "oldest requirements" leg moves fromubuntu-22.04toubuntu-24.04. Since that leg now shares an OS with the base matrix,requires: ["latest"]is added to the base matrix so it stays a separate job instead of replacing the 3.10 "latest" run (same pattern asLightning-AI/utilities). Job count is unchanged (12 + 1).pyproject.toml:pyzmq>=22.0.0→>=22.2.1. The oldest-requirements leg pins the floor, and 22.0.0 has no Python 3.10 wheels, so on 24.04 it builds from source and fails with GCC 13. 22.2.1 is the first release with cp310 wheels.Why
ubuntu-22.04deprecation began 2026-09-17, retirement 2027-04-17: [Ubuntu] The Ubuntu 22 based runner images will begin deprecation on September 17th and will be fully unsupported by April 17th for GitHub Actions and Azure DevOps actions/runner-images#14254ubuntu-latestmoves to Ubuntu 26.04 from Oct 19 to Nov 19, 2026, so floating labels would change silently: [Ubuntu]ubuntu-latestlabel will use Ubuntu 26.04 in November 2026 actions/runner-images#14748macos-14retires 2026-11-02 (not used here): [macOS] The macOS 14 Sonoma based runner images will begin deprecation on July 6th and will be fully unsupported by November 2nd for GitHub Actions and Azure DevOps actions/runner-images#13518runs-on: ubuntu-latestjobs (release, parity, minimal-deps) are left as is.