Repository navigation
Support Windows builds - #2
Open
LucasBoTang wants to merge 2 commits into
Open
LucasBoTang wants to merge 2 commits into
LucasBoTang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows builds fail because GCC warning flags are passed directly to nvcc, C11 thread-local storage is compiled in C99 mode, and CUDA 13 requires the conforming MSVC preprocessor.
This fixes those build settings, enables Windows DLL exports and installs the import library. The CLI is disabled with MSVC because it depends on POSIX headers. Two existing tests are also adjusted for Windows: environment variable handling and kernel declarations that must match their definitions.
The CUDA 13 preprocessor fix follows MIT-Lu-Lab/cuPDLPx#113. CI now covers the same seven CUDA versions on Linux and Windows: 12.4, 12.5, 12.6, 12.8, 12.9, 13.0 and 13.1. Both platforms run CPU tests and build and test the Python package on CUDA 13.1; the remaining versions check compilation and linking.
Local validation: