Skip to content

[bug] invasive procedure #2288

Open
Open

Description

@MrCandypro

Which part?

Desktop app

What happened?

The program installed itself in C: and wouldn't let me use templates on my computer. Could you make the program less picky? Not everything needs to go in C:.

What did you expect?

I was expecting a typical installation—a normal one.

How to reproduce

No response

Logs


Activity

  1. Cedric921 commented on Oct 17, 2026

    @Cedric921
    Contributor

    I would like to take this. surfsense_local/electron/electron-builder.yml has no nsis block, so the Windows installer uses electron-builder's one-click default: per user, into %LOCALAPPDATA%\Programs\SurfSense, with no folder to pick.

    Proposed change: nsis: { oneClick: false, perMachine: false, allowToChangeInstallationDirectory: true }. The installer shows a folder page, still installs per user, and needs no elevation. Updates keep running silently into the chosen folder; electron-updater reads the install location from the registry. The appId and the uninstaller key do not change, so existing installs upgrade in place.

    Two questions before I open the PR:

    1. Is moving away from one-click acceptable? The trade-off is an extra page or two on first install.
    2. The models and data (userData) stay on C: either way. Is a data-folder setting wanted here, or is that separate (it would need its own proposal)?
  2. MrCandypro commented on Oct 17, 2026

    @MrCandypro
    Author

    Yeah, that would be good. Two or three screens aren't a problem.
    It wouldn't be a problem if the important data were stored on C either; it would be great if we were informed about it.
    thanks

  3. Cedric921 commented on Oct 17, 2026

    @Cedric921
    Contributor

    Thanks @MrCandypro. #2297 adds the folder page. The installer still installs for you alone, needs no admin rights, and updates go into the folder you picked.

    On the data: models, workspaces and settings live in .surfsense in your user folder (C:\Users\<you>\.surfsense), not in the install folder. Nothing in the app says so today, so a follow-up PR will show that folder in Settings › About, with a button to open it.

  4. Cedric921 commented on Oct 17, 2026

    @Cedric921
    Contributor

    The follow-up is #2298: Settings › About now shows the data folder, with a button to open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions