fix: admin remove-by-limit input no longer deletes runs on click (#333)

[timdegroot1996]

Fixes #333

Problem

On the admin page, clicking the "outputs to remove by limit" number input (including its spinner arrows) immediately sent a DELETE /remove-outputs request, without pressing Remove and without confirmation. A down-arrow click on an empty field sent limit=-1, which removed every run in the database.

Root cause

• admin_eventlisteners.js attached the remove_outputs click handler to the #removeLimit input as well as the #removeOutputs button (since Removeruns by limit and vacuum database #188).
• _remove_by_limit only guarded limit >= len(candidates); a negative limit made the removal slice candidates[: len - limit] cover the whole list.

Fix

• Only the Remove button triggers remove_outputs.
• remove_outputs now asks for confirmation (same modal as Remove All), refuses an empty form, and rejects a limit below 1 client-side before clearing the fields.
• #removeLimit has min="1".
• RemoveOutputs.limit is Field(ge=1) → the API answers 422 for limit < 1.
• _remove_by_limit rejects limit < 1 with an error, so the CLI -r limit=0 / limit=-1 no longer wipes the database either.
• Docs note the lower bound.

Tests

• test_remove_by_limit_below_one_is_rejected (database): limit=0 / limit=-1 remove nothing and report an error.
• test_remove_outputs_by_limit_below_one_is_rejected (server): limit=0 / limit=-1 → 422, remove_outputs never called.
• Both fail without the fix; Python suite 392 passed, JS suite 266 passed.
• Manually verified against a server run from source: admin bundle has no #removeLimit listener, min="1" present, negative limit → 422.

🤖 Generated with Claude Code