Repository navigation
Improve download strategy - #81
Merged
Merged
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-grass-06127b803-81.westeurope.1.azurestaticapps.net |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Freshness comparisons and detail-page loading/error handling can produce stale or incorrect results.
Review effort: Balanced
Findings: 1
Open (6)
Parse timestamps before comparing createdDate values · New Reset loading state when preset becomes undefined · New Do not mark failed requests as missing presets · New Support legacy detail links without simType · New Reset fetch completion state for new preset requests · New Force sync when the server timestamp is unavailable · New
What changed in this PR
Centralizes preset synchronization to reduce unnecessary API requests and load only simulator-specific data.
Changes:
- Adds IndexedDB-backed, per-simulator synchronization.
- Fetches individual presets on detail pages.
- Updates stats and preset views to use cached data.
| File | Description |
|---|---|
services/presetSync.ts |
Adds centralized preset synchronization. |
pages/stats.tsx |
Loads data for the selected simulator. |
pages/preset.tsx |
Fetches and caches individual presets. |
components/sections/presets/singlePresetView/PresetView.tsx |
Supports pending preset state. |
components/sections/presets/Presets.tsx |
Replaces duplicate download logic with synchronization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-grass-06127b803-81.westeurope.1.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR focuses on avoiding / reducing unnecessary fetches of presets.
GET /{sim}/presets/{id}) instead of the entire preset list.Notes
services/presetSync.tswithsyncSim(sim), shared by the presets and stats pages.out of scope