Skip to content

Improve Python workflow #576

Open
Open

Description

@felixhekhorn
  1. Is

    - name: Set release version
    env:
    TAG: ${{ github.event.inputs.tag || github.ref_name }}
    run: |
    # Strip leading 'v' if present
    VERSION="${TAG#v}"
    echo "POETRY_DYNAMIC_VERSIONING_BYPASS=${VERSION}" >> "$GITHUB_ENV"
    still needed with
    ref: ${{ github.event.inputs.tag || github.ref }}

    in place? With that fix we don't need to patch and we can use the default behavior again, no?

  2. should we allow also the Python release workflow to be run on any commit - with the condition that we only push to PyPI on tag and else upload the artifacts to the workflow? This is essentially challenging this line

    if: startsWith(github.ref, 'refs/tags/') || github.event.inputs.tag != ''
    which should move instead below and possibly a negated branch which uploads the (already built) package as artifact

@AkshatRai07 might be able to answer these questions 🙃

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarksBenchmark (or infrastructure) related

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions