Skip to content

[FEAT] 대화창 삭제 시 모달 추가 - #48

Merged
dlrjswns merged 2 commits into
developfrom
feature/deleteModal
Sep 23, 2026
Merged

dlrjswns merged 2 commits into
developfrom
feature/deleteModal

Conversation

@dlrjswns

Copy link
Copy Markdown
Contributor

Describe

  • 대화창 삭제 시 모달 추가

Works made

  • 대화창 삭제버튼 클릭 시 ModalContainerView를 이용해 모달 표출
  • 기존 ModalContainerView 애니메이션 및 모달 표출을 위한 조건부 코드 생략을 위한 코드 개선
  • ModalContainerView를 사용하는 코드 변경

Additional context

  • 기존에 모달 표출을 위한 프로퍼티를 두고 if조건문으로 통해 분기처리했던 코드를 생략할 수 있도록 ModalContainerView코드를 개선했습니다.
  • 이후 프로젝트 내 추가될 모달은 전부 ModalContainerView활용하면 될꺼같습니다.

@dlrjswns
dlrjswns requested a review from cchanmi September 17, 2026 08:42
@dlrjswns dlrjswns self-assigned this Sep 17, 2026
@dlrjswns dlrjswns added the enhancement New feature or request label Sep 17, 2026
@dlrjswns
dlrjswns merged commit f4b2b11 into develop Sep 23, 2026
1 check failed
@dlrjswns
dlrjswns deleted the feature/deleteModal branch September 23, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant