Repository navigation
Add test for hacker device when checking for genuine - #815
Merged
Merged
Conversation
AdityaMitra5102
requested review from
daringer,
james-knippes,
mmerklinger,
robin-nitrokey and
sosthene-nitrokey
and removed request for
a team
November 3, 2026 15:09
robin-nitrokey
approved these changes
Nov 4, 2026
robin-nitrokey
force-pushed
the
genuine-hacker
branch
from
November 4, 2026 21:27
2b10a79 to
d87ce99
Compare
robin-nitrokey
temporarily deployed
to
testpypi
November 4, 2026 21:31 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from adding the check for hacker device certs, I also moved the
register_completecheck up before we test for the certificates. This is because, I feel, checking for replay resistance first before the certificates ensure a device is not passing the 'valid certificate' check with a replayed response.