Repository navigation
Conversation
This was referenced Oct 2, 2026
Member
Author
|
Note to reviewers: This is a change to a user-visible API and is therefore accompanied by downstream PRs
The trio of PRs must be reviewed and merged in concert to avoid breaking the build. |
Member
Author
|
jenkins build this opm-grid=1074 opm-simulators=7489 please |
Member
Author
|
On another note, this PR is not intended for the upcoming 2026.10 release of OPM. We need more testing than we're able to conduct before this becomes visible for all OPM users. |
bska
force-pushed
the
properly-use-compord
branch
12 times, most recently
from
October 9, 2026 11:22
76745a8 to
496c154
Compare
bska
force-pushed
the
properly-use-compord
branch
12 times, most recently
from
October 16, 2026 07:43
0aed02b to
e7b3a5e
Compare
bska
force-pushed
the
properly-use-compord
branch
from
October 26, 2026 13:22
d1eb5aa to
a9e8d62
Compare
bska
force-pushed
the
properly-use-compord
branch
10 times, most recently
from
November 2, 2026 15:01
0d1e806 to
e5250ba
Compare
bska
force-pushed
the
properly-use-compord
branch
11 times, most recently
from
November 10, 2026 11:14
de8dc01 to
23ada08
Compare
bska
force-pushed
the
properly-use-compord
branch
6 times, most recently
from
November 13, 2026 13:52
aaa661a to
47b04ef
Compare
Our existing COMPORD handling, introduced in commit 2cf06a2 (OPM/opm-parser@8f747484, OPM/opm-parser#567), does not properly handle well lists and uses a very low-level view of the SCHEDULE section structure. This commit therefore implements a keyword handler for COMPORD in terms of the ConnectionOrdering class of commit ba3f389 (PR to define the connection ordering of individual named wells, and we no longer store a Connection::Order data member within the WellConnections class. Client code must therefore query the new ScheduleState::compord data member when (transitively) calling WellConnections::order(). Similarly, WellConnections::output() gains a new Connection::Order parameter for the same reason. Update function APIs as needed to reflect the new requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our existing
COMPORDhandling, introduced in commit 2cf06a2 (OPM/opm-parser@8f747484, OPM/opm-parser#567), does not properly handle well lists and uses a very low-level view of the SCHEDULE section structure.This PR therefore implements a keyword handler for
COMPORDin terms of theConnectionOrderingclass of commit ba3f389 (PR #5401). That class then becomes the single source of truth for how to define the connection ordering of individual named wells, and we no longer store aConnection::Orderdata member within theWellConnectionsclass. Client code must therefore query the newScheduleState::comporddata member when (transitively) callingWellConnections::order(). Similarly,WellConnections::output()gains a newConnection::Orderparameter for the same reason.Update function APIs as needed to reflect the new requirements.