Skip to content

Parse CVCRIT into the Schedule - #5562

Draft
GitPaean wants to merge 1 commit into
OPM:masterfrom
GitPaean:parse-cvcrit
Draft

GitPaean wants to merge 1 commit into
OPM:masterfrom
GitPaean:parse-cvcrit

Conversation

@GitPaean

@GitPaean GitPaean commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Store CVCRIT in ScheduleState::cvcrit(), in SI units, and raise ScheduleEvents::CVCRIT_CHANGE at the report step where the keyword appears. This lets the compositional simulator apply it, e.g. the convergence criteria in OPM/opm-simulators#7481.

All items are stored except those for SAMG (33, 34), Appleyard chopping (40), the extra linear residual checks (10, 22) and the reserved ones. Every item has a default, so unlike TUNING each CVCRIT starts from the defaults: an item defaulted in the deck takes its default rather than its value from an earlier CVCRIT. Items 2, 4, 6, 7, 9, 13, 14 and 15 have no value until the deck sets them, since their defaults depend on the solution method or on other keywords. Item 13 has no unit in the keyword definition and is stored as given.

SKIPREST keeps CVCRIT, since the restart file does not store it.

@GitPaean GitPaean added the manual:enhancement This is an enhancement/improvent that needs to be documented in the manual label Nov 12, 2026
@GitPaean

Copy link
Copy Markdown
Member Author

jenkins build this opm-simulators=7686 please

@GitPaean
GitPaean force-pushed the parse-cvcrit branch 2 times, most recently from 720321d to f982b2b Compare November 13, 2026 11:40
@GitPaean

Copy link
Copy Markdown
Member Author

jenkins build this please

@GitPaean

Copy link
Copy Markdown
Member Author

jenkins build this with opm-simulators=7686 please

@GitPaean

Copy link
Copy Markdown
Member Author

jenkins build this with opm-simulators=7686 please

@GitPaean

Copy link
Copy Markdown
Member Author

jenkins build this with opm-simulators=7686 please

Store the CVCRIT items that Flow can use in ScheduleState and raise
CVCRIT_CHANGE where the keyword appears. Every item has a default, so an
item defaulted in the deck takes that default rather than its value from
an earlier CVCRIT.

SKIPREST keeps CVCRIT, since the restart file does not store it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:enhancement This is an enhancement/improvent that needs to be documented in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant