Repository navigation
Conversation
GitPaean
force-pushed
the
parse-cvcrit
branch
from
November 12, 2026 14:59
daf8b5e to
f27c426
Compare
Member
Author
|
jenkins build this opm-simulators=7686 please |
GitPaean
force-pushed
the
parse-cvcrit
branch
2 times, most recently
from
November 13, 2026 11:40
720321d to
f982b2b
Compare
Member
Author
|
jenkins build this please |
Member
Author
|
jenkins build this with opm-simulators=7686 please |
GitPaean
force-pushed
the
parse-cvcrit
branch
from
November 13, 2026 23:15
f982b2b to
b21dd72
Compare
Member
Author
|
jenkins build this with opm-simulators=7686 please |
GitPaean
force-pushed
the
parse-cvcrit
branch
from
November 14, 2026 06:30
b21dd72 to
e6eacb0
Compare
Member
Author
|
jenkins build this with opm-simulators=7686 please |
Store the CVCRIT items that Flow can use in ScheduleState and raise CVCRIT_CHANGE where the keyword appears. Every item has a default, so an item defaulted in the deck takes that default rather than its value from an earlier CVCRIT. SKIPREST keeps CVCRIT, since the restart file does not store it.
GitPaean
force-pushed
the
parse-cvcrit
branch
from
November 17, 2026 14:17
e6eacb0 to
6521ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store CVCRIT in
ScheduleState::cvcrit(), in SI units, and raiseScheduleEvents::CVCRIT_CHANGEat the report step where the keyword appears. This lets the compositional simulator apply it, e.g. the convergence criteria in OPM/opm-simulators#7481.All items are stored except those for SAMG (33, 34), Appleyard chopping (40), the extra linear residual checks (10, 22) and the reserved ones. Every item has a default, so unlike TUNING each CVCRIT starts from the defaults: an item defaulted in the deck takes its default rather than its value from an earlier CVCRIT. Items 2, 4, 6, 7, 9, 13, 14 and 15 have no value until the deck sets them, since their defaults depend on the solution method or on other keywords. Item 13 has no unit in the keyword definition and is stored as given.
SKIPREST keeps CVCRIT, since the restart file does not store it.