Repository navigation
Skip injectors in the auto-choke group THP solve - #7702
Open
hakonhagland wants to merge 1 commit into
Open
hakonhagland wants to merge 1 commit into
hakonhagland wants to merge 1 commit into
Conversation
The group THP of an automatic choke is found by solving the wells of
the group at trial THP values and comparing their summed rate with
the group target. The loop over the wells did not test the well
type, so an injector in the group was asked for its production
controls, and the time step ended with
Trying to get production data from an injector
The loop goes over the wells of one MPI rank, so in a parallel run
only the ranks that own such an injector threw.
Skip injectors in that loop, as the loop that applies the resulting
THP already does.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
Author
|
jenkins build this please |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change excluding injectors from the automatic-choke THP rate calculation.
No open issues 🎉
What changed in this PR
Fixes the automatic-choke group tubing-head pressure (THP) solve so groups containing injectors do not request production controls from those wells.
Changes:
- Skips injectors when evaluating trial THP values and summing production rates against the group target.
- Adds a comment explaining why injectors are excluded, matching the existing behavior when applying the resulting THP.
| File | Description |
|---|---|
opm/simulators/wells/BlackoilWellModelNetwork_impl.hpp |
Adds an injector guard to the automatic-choke rate-mismatch loop. |
Review effort: Balanced
Member
|
Thanks for the review request. You pointed to some other open PRs related, let me evaluate the relations between them. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group THP of an automatic choke is found in
computeWellGroupThp()by solving the wells of the group at trial THP values and comparing their summed rate with the group target. The loop over the wells in the lambdamismatchdid not test the well type, so an injector in the group was asked for its production controls, and the time step ended with "Trying to get production data from an injector". The loop goes over the wells of one MPI rank, so in a parallel run only the ranks that own such an injector throw.Skip injectors in the THP solve (commit 1)
mismatch, skip wells that are injectors. The loop that applies the resulting THP already skips them. The choke regulates the production of the group, so an injector takes no part in the rate that is matched against the target.Reproducer
The deck
NETWORK_MODEL5_STDW_AUTOCHK.DATAof opm-tests, with three changes: the water injector G-3H moved into the automatic-choke group (its group in WELSPECS fromG1toB1), the WCONINJE keyword moved after NODEPROP, and G-3H onRATEcontrol instead ofGRUP. On master the run stops in time step 0 with the exception above. With this PR it runs on to time step 3 and stops there as the unchanged deck does on master, for an unrelated reason (cmode: NONEfor group B1).No deck test is added: no automatic-choke deck of opm-tests runs to its end on master today, so there is no regression test to extend.
Related PRs
Testing
🤖 Generated with Claude Code