Skip to content

chore: [SDK-5637] add extra IAM type buttons to demo app - #325

Merged
fadi-george merged 1 commit into
mainfrom
fadi/sdk-5637
Oct 30, 2026
Merged

fadi-george merged 1 commit into
mainfrom
fadi/sdk-5637

Conversation

@fadi-george

@fadi-george fadi-george commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Adds HTML, Full Bleed, Carousel, and Carousel Bleed IAM buttons to the demo app and lays out all 8 in a 2-column grid.

iOS Android

Details

Motivation

Lets us test the extra IAM layouts from the demo app. Follows the shared spec update in OneSignal/sdk-shared#66 and matches iOS (OneSignal/OneSignal-iOS-SDK#1787).

Scope

  • Labels are now Top, Bottom, Center, HTML, Full, Full Bleed, Carousel, Carousel Bleed (uppercased). Existing iam_type values and test IDs (send_iam_{type}_button) are unchanged.
  • InAppMessageType: 4 new members in grid order.
  • SendIamSection: 2-column grid with columnGap: AppSpacing.gap. Row gap comes from the button's existing bottom margin.
  • ActionButton: optional singleLine prop (one line, adjustsFontSizeToFit, 8px side padding). Other buttons are unchanged.
  • Demo app only. No plugin changes.

Testing

Manual testing

Ran vp check and vp test. Checked the grid with a release build on an Android 16 emulator.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible
  • I have tested this on the latest version of the plugin
  • I have tested this on both Android and iOS, or explained why that is not possible (Android emulator only; demo UI change is cross-platform JS)

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george requested a review from a team as a code owner October 30, 2026 18:43
@fadi-george
fadi-george merged commit ba9726a into main Oct 30, 2026
5 checks passed
@fadi-george
fadi-george deleted the fadi/sdk-5637 branch October 30, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants