[donghaiwang]

Description

Fixes #

Where has this been tested?

• Platform(s): ...
• Python version(s): ...
• Unreal Engine version(s): ...

Possible Drawbacks

[beyond-ovo]

I found five issues worth fixing in this revision. The first one prevents the new launcher path from working; the others make the new CI check incomplete or regress an existing test mode.

1. High — CarlaAir.ps1:354

   The new vehicle selector reads AirSimConfig\settings_rov.json or settings_drone.json, but the templates added by this PR live under Unreal\CarlaUE4. Package.bat stages settings_rov.json at the package root and does not create AirSimConfig. On a clean checkout or packaged build, --vehicle rov therefore reaches the missing-template check and exits before launching; if an old fallback happens to exist, it can silently run the wrong mode. Please make the source and package locations consistent, including both templates.

2. Medium — Util/BuildTools/Check.bat:367

   The test server is started with --carla-rpc-port=3654 at line 185, but this invocation leaves the test --port at its default value of 2000. test_carla_actor() consequently probes the wrong endpoint and only prints a skip message. Pass --port 3654 (or start CARLA on 2000) so the new registry check actually reaches the service.

3. Medium — PythonAPI/test/holoocean/airsim_rov.py:115-116

   Most of the new test is allowed to pass without verifying its stated checks: the CARLA actor result is ignored, the IMU/barometer/magnetometer and camera calls catch all exceptions, and an empty image only prints a message. The script can therefore print ALL ROV TESTS COMPLETED SUCCESSFULLY! and return 0 with no sensor, camera, or actor coverage. Mandatory checks should fail the test, or optional checks should be labeled as such instead of contributing to the success claim.

4. Medium — PythonAPI/test/holoocean/airsim_rov.py:43-44

   If an installed airsim package imports successfully but lacks RovClient, line 26 raises ImportError while that module remains cached in sys.modules. Every import airsim in the fallback loop then reuses the cached module, so the local candidate can never be loaded. Remove the cached module before retrying or load the candidate explicitly.

5. Medium — Util/BuildTools/Check.bat:78

   BUILD_FOLDER and exe_path are now computed before argument parsing, while --debug sets IS_DEBUG only at line 97. As a result, Check.bat --debug --water still selects the release package and copies the ROV settings there. Recompute these paths after parsing, or keep the selection block after :arg-parse.

All 15 changed files were checked: 11 with the OCR rules and the 4 files excluded by OCR manually. The added Python files parse successfully, both new JSON files are valid, and I did not find additional issues in the ROV RPC method or type mappings.

[beyond-ovo]

how do u think