Add ssc337de_lite_zte-k543 device profile (ZTE K543, SC401AI, MT7601U Wi-Fi) - #152
Conversation
PR Summary by QodoAdd ZTE K543 SSC337DE Lite device profile
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Code Review by Qodo
1. Wireless setup failures report success
|
There was a problem hiding this comment.
🟡 Changes recommended
There are a couple of correctness/consistency issues to address (notably a future “reconciled” date and excludes-list convention/size-trimming alignment).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new OpenIPC builder device overlay for the ZTE K543 PTZ camera (SigmaStar SSC337DE / SC401AI / MT7601U, 16 MiB NOR), providing per-device Buildroot defconfig, first-boot customizer settings, wireless init override, and a device-specific excludes list.
Changes:
- Add
ssc337de_lite_zte-k543device directory with defconfig, customizer, wireless init script, and rootfs exclude list. - Register the device in the README device table.
- Record the device’s
etc/wireless/usbshadow in.github/firmware-drift.json.
File summaries
| File | Description |
|---|---|
| README.md | Adds ZTE K543 to the supported devices table. |
| devices/ssc337de_lite_zte-k543/general/scripts/excludes/ssc337de_lite.list | New device-specific rootfs trimming list (sensor/NFS modules). |
| devices/ssc337de_lite_zte-k543/general/overlay/usr/share/openipc/customizer.sh | First-boot runtime configuration (Majestic, PTZ GPIOs, audio, upgrade URL). |
| devices/ssc337de_lite_zte-k543/general/overlay/etc/wireless/usb | Device-specific MT7601U init (GPIO 14 toggle + modprobe). |
| devices/ssc337de_lite_zte-k543/br-ext-chip-sigmastar/configs/ssc337de_lite_zte-k543_defconfig | Buildroot/OpenIPC configuration for SSC337DE lite + SC401AI + MT7601U + gpio-motors. |
| .github/firmware-drift.json | Adds a shadow entry for the device-local wireless script. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
349aeb7 to
3dbe169
Compare
openipc-ai
left a comment
There was a problem hiding this comment.
Thanks — and sorry this sat unbuilt for two days: a PR from a first-time contributor needs a maintainer to release the workflow run. Reviewed against master e0a643f with firmware at 9e7cf5b; nothing here blocks, so I am releasing the build now.
This is unusually well put together for a first device PR. Three things I verified rather than took on trust:
- The
firmware-drift.jsonentry is exactly right.f9df96bc190e8f8a11794f9410568eac10f50320is the current blob of firmware'sgeneral/overlay/etc/wireless/usbat HEAD — I resolved it independently and it matches. Most contributors do not know that file exists; registering the overlay there is the difference between a tracked divergence and a silent one. - The exclude list keeps the right sensor.
OpenIPC/sensorsbuilds 18 sensors forsigmastar/infinity6b0, your list prunes 17 of them and leavessc401ai— the board's own — in place. mt7601stais the right module name:mt7601u-openipcbuilds the vendor STA driver (it installs/etc/mediatek/MT7601USTA.dat), and three existing upstream profiles modprobe that same name. The kernel config you point at,infinity6b0-ssc009b.config, is the one the other ssc337de device in the tree uses.
One nit: /lib/modules/4.9.84/sigmastar/sensor_jxq03_mipi.ko is not built for infinity6b0 — that sensor exists for other families but not this one — so the entry will never match anything, and rootfs_script.sh will count it in its excludes: N of M entries matched no file line. Harmless, just drop the line.
ci-matrix.py --stdin on your branch narrows to exactly one device, so this is a single build. Let's see what it says.
3dbe169 to
b4094c4
Compare
Adds a device profile for the ZTE K543 PTZ camera — SigmaStar SSC337DE (Infinity6B0), SC401AI sensor, 16 MiB NOR, and MT7601U USB Wi-Fi.
The board needs a few device-specific settings beyond the standard SSC337DE lite configuration:
mt7601sta; the device-specific wireless overlay implements this and is tracked infirmware-drift.json.gpio-motors.Tested on a physical ZTE K543: the firmware builds, flashes and boots successfully; SC401AI video, MT7601U Wi-Fi, IR-cut/night mode, speaker output, and both PTZ axes are working.
All repository checks pass (
ci-matrix,check-firmware-drift --self-test,lint-cli-paths,lint-workflow-shell, and shell syntax validation).