Skip to content

feat: show that every data owner approved an enclave job - #9629

Draft
atlaie wants to merge 1 commit into
devfrom
atlaie/enclave-msg-approval-status
Draft

atlaie wants to merge 1 commit into
devfrom
atlaie/enclave-msg-approval-status

Conversation

@atlaie

@atlaie atlaie commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Once every data owner has approved an enclave job:

  • with nothing requested, a data owner sees "Approved by all: every data owner approved; nothing was requested" instead of "needs the approval of every party";
  • Approval shows "every data owner" instead of "—" in the job view, str(job) and the job lists.

The enclave records its approval outside the job state that the display reads. A display-only _approval_label() covers that; approval_method is unchanged, because syft-bg's approve handler reads it. Display only; no behaviour change.

Not covered: when something was requested, a data owner still sees "needs the approval of every party", since it holds only its own approval file.

One of five small PRs from the 13 Nov enclave test; each merges cleanly with the others and with #9576.

Asana: https://app.asana.com/0/0/1220519960557651/f

🤖 Generated with Claude Code

No rush: after the release.

A data owner sees "every data owner approved; nothing was requested"
instead of "needs the approval of every party" once that is so, and the
approval shows "every data owner" instead of "—": the enclave records its
approval outside the state that the display reads. approval_method is
unchanged, since syft-bg's approve handler reads it.

Messages, display and docstrings only; no behaviour change.
Asana: https://app.asana.com/0/0/1220519960557651/f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant