Repository navigation
Conversation
A data owner sees "every data owner approved; nothing was requested" instead of "needs the approval of every party" once that is so, and the approval shows "every data owner" instead of "—": the enclave records its approval outside the state that the display reads. approval_method is unchanged, since syft-bg's approve handler reads it. Messages, display and docstrings only; no behaviour change. Asana: https://app.asana.com/0/0/1220519960557651/f Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once every data owner has approved an enclave job:
str(job)and the job lists.The enclave records its approval outside the job state that the display reads. A display-only
_approval_label()covers that;approval_methodis unchanged, because syft-bg's approve handler reads it. Display only; no behaviour change.Not covered: when something was requested, a data owner still sees "needs the approval of every party", since it holds only its own approval file.
One of five small PRs from the 13 Nov enclave test; each merges cleanly with the others and with #9576.
Asana: https://app.asana.com/0/0/1220519960557651/f
🤖 Generated with Claude Code
No rush: after the release.