Repository navigation
fix: log checkpoint and rolling-state load failures instead of printing - #9635
Open
VenishPaneliya wants to merge 1 commit into
Open
VenishPaneliya wants to merge 1 commit into
VenishPaneliya wants to merge 1 commit into
Conversation
Three recovery paths in ConnectionRouter print a hand-prefixed "Warning: ..." to stdout, so a caller cannot silence, capture or route the message. The module already imports logging, defines a module logger and uses logger.warning for the same kind of recoverable problem elsewhere in the file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three recovery paths in
ConnectionRouterprint a hand-prefixed"Warning: ..."to stdout:get_latest_checkpoint(line 492)get_all_incremental_checkpoints(line 535)get_rolling_state(line 572)Each catches an exception, tells the user, and continues — but via
print, so the message cannot be silenced, captured or routed, and in a notebook it lands in the cell output.The module already imports
logging, defineslogger = logging.getLogger(__name__), and useslogger.warningfor the same kind of recoverable problem (unknown peer protocol schema, unknown peer state). These were the only threeprintcalls in the file. The"Warning: "prefix goes away with the switch, since the level carries it.ruff check,ruff formatandblackreport no change againstdevon this file.