Repository navigation
fix(gdrive): paginate folder listing in _download_folder - #9637
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
files().list returns at most one page; _download_folder ignored nextPageToken, so folders with more results silently lost files. Follow nextPageToken until exhausted. Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_download_folderinsyft/gdrive_utils.pycalledfiles().listonce, requested onlyfiles(id,name,mimeType)(nonextPageToken) and never followed pagination. For folders with more results than one page, the remaining files were silently skipped while the call reported success.Changes
nextPageTokeninfieldsand loop, passingpageToken, until no token is returned (same pattern asDriveCachedClient.get_file_metadatas_from_folder).Testing
tests/unit/test_gdrive_utils_pagination.py: a two-page response (empty first page withnextPageToken, file on the second) must download the second-page file and resend the token. Fails before the fix (1 list call), passes after.tests/unit/test_gdrive_pagination.pystill passes (12 passed in total).Asana task
Not applicable.
AI assistance was used to prepare this change and its tests.
Local validation
Base: dev 425d615 (default branch is dev, not main).
No issue exists for this finding, so there is no Fixes reference.