Skip to content

ToupTek: keep capture running when changing ROI - #1479

Merged
agalasso merged 2 commits into
OpenPHDGuiding:masterfrom
Indigo2233:codex/touptek-roi-capture
Nov 2, 2026
Merged

agalasso merged 2 commits into
OpenPHDGuiding:masterfrom
Indigo2233:codex/touptek-roi-capture

Conversation

@Indigo2233

Copy link
Copy Markdown
Contributor

Switching between full-frame and subframe capture can leave my monochrome G3M678M waiting for frames. I reproduced this with SDK digital binning as well.

Keep the capture session running when updating ROI between triggers, and abort capture if the ROI update fails. Split out of #1478; based directly on master.

Earlier G3M678M tests covered full-frame/ROI transitions in 8- and 16-bit modes. This extracts the same fix unchanged. Formatting passes; the split branch has not been separately rebuilt or rerun on hardware.

@agalasso agalasso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr. which camera(s) was this tested on? I will test with the Touptek cameras I have access to & let you know what I find.

@agalasso agalasso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test with 3 Touptek camera models and was able to confirm that at least with these camera models StopCapture() is not required before setRoi().

  • GPCMOS2000KPA
  • GCMOS1200KMB
  • G3M178C

Comment thread src/cam_touptek.cpp Resolved
@Indigo2233

Copy link
Copy Markdown
Contributor Author

thanks for the pr. which camera(s) was this tested on? I will test with the Touptek cameras I have access to & let you know what I find.

I tested on G3M678m

Set the ROI without stopping the capture session first, so the capture keeps
running across ROI changes between triggers. Verified on GPCMOS2000KPA,
GCMOS1200KMB and G3M178C that StopCapture() is not required before SetRoi().
@agalasso
agalasso merged commit 264a64d into OpenPHDGuiding:master Nov 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants