Repository navigation
ToupTek: keep capture running when changing ROI - #1479
Merged
agalasso merged 2 commits intoNov 2, 2026
Merged
Conversation
agalasso
reviewed
Nov 1, 2026
agalasso
left a comment
Contributor
There was a problem hiding this comment.
thanks for the pr. which camera(s) was this tested on? I will test with the Touptek cameras I have access to & let you know what I find.
agalasso
reviewed
Nov 1, 2026
agalasso
left a comment
Contributor
There was a problem hiding this comment.
I was able to test with 3 Touptek camera models and was able to confirm that at least with these camera models StopCapture() is not required before setRoi().
- GPCMOS2000KPA
- GCMOS1200KMB
- G3M178C
Contributor
Author
I tested on G3M678m |
Set the ROI without stopping the capture session first, so the capture keeps running across ROI changes between triggers. Verified on GPCMOS2000KPA, GCMOS1200KMB and G3M178C that StopCapture() is not required before SetRoi().
agalasso
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching between full-frame and subframe capture can leave my monochrome G3M678M waiting for frames. I reproduced this with SDK digital binning as well.
Keep the capture session running when updating ROI between triggers, and abort capture if the ROI update fails. Split out of #1478; based directly on master.
Earlier G3M678M tests covered full-frame/ROI transitions in 8- and 16-bit modes. This extracts the same fix unchanged. Formatting passes; the split branch has not been separately rebuilt or rerun on hardware.