Skip to content

Allow a one-use MinMo bypass in set_lock_position - #1480

Closed
Atlas8m wants to merge 1 commit into
OpenPHDGuiding:masterfrom
Atlas8m:set-lock-position-minmo-bypass
Closed

Atlas8m wants to merge 1 commit into
OpenPHDGuiding:masterfrom
Atlas8m:set-lock-position-minmo-bypass

Conversation

@Atlas8m

@Atlas8m Atlas8m commented Oct 28, 2026

Copy link
Copy Markdown

Summary

Add an optional boolean parameter bypass_min_move (default false)
to the set_lock_position RPC method.

Motivation

Automated target acquisition, such as placing a star on a spectrograph
slit or fiber feed, can require a final adjustment smaller than the MinMo
used for normal guiding. The deadband can prevent that adjustment.
This option allows the controller to request it without changing the
saved MinMo settings.

Changes

  • Add the optional bypass_min_move parameter to set_lock_position.
  • When true, allow a correction below MinMo on the next guide frame only.
    If that frame cannot produce a correction, another request is needed.
  • Using bypass_min_move: true requires exact: true and active,
    unpaused guiding.
  • Keep the immediate RPC response and saved MinMo settings unchanged.
    Other guiding rules and pulse-duration limits still apply.
  • Preserve existing behavior when the parameter is omitted or false.

Example

{
  "method": "set_lock_position",
  "params": {
    "x": 120.5,
    "y": 240.5,
    "exact": true,
    "bypass_min_move": true
  },
  "id": 1
}

Testing

  • Built with Visual Studio 2022 on Windows x64.
  • An external PPEC unit test verified a correction below MinMo with bypass
    enabled, followed by a normal call that obeyed MinMo again.
  • Built-in Simulator RPC checks with RA Hysteresis MinMo set to 5 pixels:
    a 1-pixel lock change produced one sub-MinMo correction, followed by
    normal MinMo behavior. Repeating the request allowed another correction.
    Saved algorithm settings were unchanged.
  • Checked the original three-parameter call, named and positional
    parameters, and rejection of invalid bypass arguments.

Add optional bypass_min_move for the next guide-image update. Carry the
override with one ordinary guide move without changing configured MinMo
values.

Keep the setter immediate and the original behavior when the flag is
omitted. Repeated requests at the same coordinates rearm the override
without restarting lock-change handling.
@bwdev01

bwdev01 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

I don't see any sense in this, is this just a theoretical problem? Let's say you do this and you end up with a zero displacement from the lock point. In the very next guide camera frame, the target can have moved off target due to seeing conditions and various mechanical errors, At that point, no correction will be issued less than the MinMove and you will no longer have a zero displacement. What image scale are you using? Is you need this kind of precision, you need to be guiding at a fine image scale, probably less than 1 arc-sec/px. MinMove values are expected to be at or below the typical size of the seeing fluctuations and can be as low as 0.1 px. I don't think we should pursue this.

@Atlas8m

Atlas8m commented Oct 28, 2026 •

Copy link
Copy Markdown
Author

I don't see any sense in this, is this just a theoretical problem? Let's say you do this and you end up with a zero displacement from the lock point. In the very next guide camera frame, the target can have moved off target due to seeing conditions and various mechanical errors, At that point, no correction will be issued less than the MinMove and you will no longer have a zero displacement. What image scale are you using? Is you need this kind of precision, you need to be guiding at a fine image scale, probably less than 1 arc-sec/px. MinMove values are expected to be at or below the typical size of the seeing fluctuations and can be as low as 0.1 px. I don't think we should pursue this.

Thanks for the feedback, but I believe there is a fundamental difference between steady-state seeing rejection and external deterministic positioning (e.g., fiber/slit injection).

1. DC Systematic Offset vs. AC Seeing Jitter

Seeing fluctuations are zero-mean stochastic noise ($\mu = 0, \sigma > 0$). Over a typical scientific exposure (several minutes), the star's energy profile integrates symmetrically around the mean centroid.

MinMo acts as a deadband. When an external acquisition controller (e.g., for fiber coupling or slit spectroscopy) determines that the star centroid has an uncorrected systematic offset of, say, $+0.15\text{ px}$, leaving it uncorrected because of MinMo means the telescope will permanently track with that systematic DC bias. For a 50 µm fiber or narrow slit, even a small fraction of a pixel in DC offset translates directly into significant throughput loss. Seeing jitter broadens the integrated PSF, but an uncorrected DC bias clips it off the aperture.

2. Why not just lower MinMo globally?

Lowering MinMo globally down to 0.05–0.1 px during normal guiding causes the loop to chase the seeing, resulting in unnecessary mechanical strain, gear reversals, and RMS degradation. That is precisely why MinMo exists.

However, set_lock_position with bypass_min_move is a deterministic feed-forward command initiated by an external supervisory loop, not random seeing noise. Suppressing an explicit external control command using a statistical noise threshold meant for passive tracking defeats the purpose of external positioning.

3. Slit-Viewing & IFU Architectures Dictate Plate Scale

Telling users to simply "guide at a finer image scale (<1''/px)" overlooks standard spectrograph optomechanical design:

  • Slit-jaw / slit-viewing optics frequently incorporate focal reduction specifically to enlarge the field of view, ensuring a sufficient probability of acquiring suitable guide stars around faint science targets.
  • Integral Field Units (IFUs) deployed on fast or moderate-focal-length instruments physically operate at coarser plate scales, typically $1.5\text{–}2.5''\text{/px}$.

At a scale of $1.5\text{–}2.5''\text{/px}$, an uncorrected $0.15\text{ px}$ deadband corresponds to $\sim 0.25\text{–}0.38''$. On a $1.0''$ slit or a tight fiber aperture, that systematic DC offset eats up 25% to 40% of the entire aperture budget. Reconfiguring the focal reduction optics or compromising guide-star FOV just to satisfy an arbitrary software deadband is physically impractical.

This change is strictly opt-in (default = false), preserves 100% backward compatibility, and allows PHD2 to be reliably integrated into scientific target acquisition pipelines without degrading normal guiding behavior.

@bwdev01

bwdev01 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

I'm not willing to spend more time trying to educate your Chatbot. You can just pursue this using a private, unsupported version of PHD2 that you build yourself.

@Atlas8m

Atlas8m commented Oct 28, 2026

Copy link
Copy Markdown
Author

I'm not willing to spend more time trying to educate your Chatbot. You can just pursue this using a private, unsupported version of PHD2 that you build yourself.

Crying chatbot is just an easy excuse to run away when you can not defend your bad logic. You can not even tell the difference between random seeing shake and a real tracking error when an instrument needs a precise locking position, and you clearly do not understand slit physics or photon loss. Do not talk about educating anyone. Go back to your backyard and take pretty pictures for blurry desktop wallpapers. Keep your toy software for amateur eye candy. Real instruments will run on a real fork. Forked and closed.

@bwdev01 bwdev01 closed this Oct 28, 2026
@daleghent

daleghent commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

@Atlas8m wrote:

Crying chatbot is just an easy excuse to run away when you can not defend your bad logic. You can not even tell the difference between random seeing shake and a real tracking error when an instrument needs a precise locking position, and you clearly do not understand slit physics or photon loss. Do not talk about educating anyone. Go back to your backyard and take pretty pictures for blurry desktop wallpapers. Keep your toy software for amateur eye candy. Real instruments will run on a real fork. Forked and closed.

@Atlas8m I see the problem as failure to personally and adequately explain the theory and reasoning behind your submission in the description of the PR. The only thing that is explained is the code change itself while the reasoning for it is given only a very weak gesture in the Motivation section. Only after being prompted to did you supply an obviously agent-generated word-salad explanation of the whys and hows. "Zero-mean stochastic noise?" "Systemic DC bias?" Seriously? Nobody real talks like that outside of dry papers, and tossing back an agent-generated word salad is rather disrespectful. The PR would be far more believable and the motivations for it far more understandable if you could advocate for the change and explain its theory in your own words. After all, if you can't explain the change you're offering, why should anyone else take time out of their day to divine that explanation themselves? This leads anyone who is a competent developer to conclude:

  1. The person behind the PR does not understand the existing system and why it is the way it is.
  2. The person behind the PR cannot explain the change and its theory without external assistance. This is referred to as "being a meatproxy".
  3. And, because of the above, the person behind the PR is quite likely unwilling to "own" the code they are submitting, leaving any future documentation needs and unforeseen regressions or problems with it up to someone else. For example, there does not seem to be a corresponding PR to update the Wiki, which is where the event API is documented. Nor is there an explanation as to why this is an API-only configuration parameter. And so-on.
  4. Aside from the description of the change, such as it is, no supporting documentation of the change in action has been supplied. At a minimum I would expect comparative guide logs. Given the nature of the change, perhaps even a video recording of the change in action might also be called for. But there's nothing in the PR that shows you've even tried this change in the field, let alone exhaustively.

On top of that, you seem to be unfamiliar with basic development norms and etiquette. That can catch up to you.

@Atlas8m

Atlas8m commented Nov 16, 2026

Copy link
Copy Markdown
Author

@Atlas8m wrote:

Crying chatbot is just an easy excuse to run away when you can not defend your bad logic. You can not even tell the difference between random seeing shake and a real tracking error when an instrument needs a precise locking position, and you clearly do not understand slit physics or photon loss. Do not talk about educating anyone. Go back to your backyard and take pretty pictures for blurry desktop wallpapers. Keep your toy software for amateur eye candy. Real instruments will run on a real fork. Forked and closed.

@Atlas8m I see the problem as failure to personally and adequately explain the theory and reasoning behind your submission in the description of the PR. The only thing that is explained is the code change itself while the reasoning for it is given only a very weak gesture in the Motivation section. Only after being prompted to did you supply an obviously agent-generated word-salad explanation of the whys and hows. "Zero-mean stochastic noise?" "Systemic DC bias?" Seriously? Nobody real talks like that outside of dry papers, and tossing back an agent-generated word salad is rather disrespectful. The PR would be far more believable and the motivations for it far more understandable if you could advocate for the change and explain its theory in your own words. After all, if you can't explain the change you're offering, why should anyone else take time out of their day to divine that explanation themselves? This leads anyone who is a competent developer to conclude:

  1. The person behind the PR does not understand the existing system and why it is the way it is.
  2. The person behind the PR cannot explain the change and its theory without external assistance. This is referred to as "being a meatproxy".
  3. And, because of the above, the person behind the PR is quite likely unwilling to "own" the code they are submitting, leaving any future documentation needs and unforeseen regressions or problems with it up to someone else. For example, there does not seem to be a corresponding PR to update the Wiki, which is where the event API is documented. Nor is there an explanation as to why this is an API-only configuration parameter. And so-on.
  4. Aside from the description of the change, such as it is, no supporting documentation of the change in action has been supplied. At a minimum I would expect comparative guide logs. Given the nature of the change, perhaps even a video recording of the change in action might also be called for. But there's nothing in the PR that shows you've even tried this change in the field, let alone exhaustively.

On top of that, you seem to be unfamiliar with basic development norms and etiquette. That can catch up to you.

@daleghent Let me make this as simple and plain as possible so nobody cries about "AI words" again.

  1. Attitude and "etiquette": I opened a clean PR and only pushed back after getting a dismissive "I don't see any sense in this" right out of the gate. Explaining basic physics is not bad manners. Calling someone a "meatproxy" because you dislike normal engineering terms is.

  2. Physics and the PR itself: You completely miss the difference between random seeing shake and a steady offset error. Putting a star onto a spectrograph slit or IFU (fiber, image slicer, microlens array) requires sub-arcsecond accuracy, and a MinMove deadzone blocks that last tiny step. And you clearly did not even read the PR properly. It was a single optional, one-shot RPC flag (bypass_min_move, default false) that changed zero default behavior, which is why it did not need a UI setting or a long essay.

  3. Testing and simulation: Demanding real sky logs or a screen recording for a tiny RPC flag is funny. I run a full Software-in-the-Loop (SIL) simulator that models periodic error, axis vibration, backlash, seeing blur, image motion, and real Zemax optical PSFs (even defocused pupils). Nobody tests space telescope control fixes by blindly uploading them to orbit first. That is what high-fidelity simulation is for.

  4. Architecture and why I walked away: I built an automated observing system with wxWidgets eight years ago, so I know its coupling problems inside out. Most amateur astronomy apps mash UI and control logic into one giant window. If the UI freezes or crashes, the whole night dies with it. NINA is a classic example, and I have used it. After observing at Keck and talking with their software engineers in Hawaii and at SPIE, it is obvious that separating a headless control server from the UI is the serious way to build instrument software. Also, trying to stay cross-platform for Linux and Mac forces too many compromises when vendor camera SDKs and USB drivers on those systems are often missing or unstable (I think this is a reason why SharpCap is Windows only). Digging back into PHD2's coupled codebase made me realize patching it was a dead end. In my own guiding software, the guiding loop runs completely inside a headless server without needing a UI. I can close the UI right after setup, or connect remotely for maintenance without ever touching Remote Desktop.

I truly respect the original PHD2 authors for building and maintaining this open-source tool for so many years. That respect does not extend to this kind of gatekeeping lecture. Honestly, I am glad this happened. It broke my inertia of trying to patch an amateur tool, and now my own headless guiding system is running cleanly on Windows without needing anyone's permission. Perhaps I will open source my whole software bundle once they are mature enough after completing multiple rounds of Hardware-in-Loop testing with real gears and real observing condition. Done here.

image image image image image

@daleghent

Copy link
Copy Markdown
Contributor

@daleghent Let me make this as simple and plain as possible so nobody cries about "AI words" again.

  1. Attitude and "etiquette": I opened a clean PR and only pushed back after getting a dismissive "I don't see any sense in this" right out of the gate. Explaining basic physics is not bad manners. Calling someone a "meatproxy" because you dislike normal engineering terms is.

You neglected to provide any supporting materials to support your proposal. This would be a non-starter even before the age of AI. There were no logs or anything of substantive nature to demonstrate the change has benefits in a context that extends to more than just yourself and your specific operational circumstances. Merely showing that the code compiles does and the boolean gets fiddled via API call does not constitute adequate testing in any setting. You're introducing an option that affects guiding methodologies and performance and may have unintended ramifications or effect on systems other than your own, so it should have been obvious that you will need to supply evidence to back it up.

How you came across is that it seems you presumed your change would be unquestionably accepted with the paltry amount of information submitted with it, and are annoyed that you were asked to further explain it. Your response was to throw an agent-generated word salad back in the face of the requestor, as if you were annoyed at being asked to do so. It's not a genuine act, to start, and it's seen as disrespectful. Bruce asked for your explanation, not an LLM's. Bruce could have just prompted any AI himself if he wanted an AI-based breakdown of the change. But he asked for yours. That's not gatekeeping. It's his project after all and he has to answer for everything that goes into it.

Then there's your rather unprofessional personal mocking at the end. It's good that you're here under an alias rather than presenting in any professional capacity. Speaking of which, since you claim to work in the research space, it would be good to supply your account with your ORCiD code.

As for, Meatproxy, it's now part of the engineering lexicon and is wholly descriptive of a process. Recruiters even use it now, usually to explain what they're not looking for.

@Atlas8m

Atlas8m commented Nov 16, 2026

Copy link
Copy Markdown
Author

@daleghent Let me make this as simple and plain as possible so nobody cries about "AI words" again.

  1. Attitude and "etiquette": I opened a clean PR and only pushed back after getting a dismissive "I don't see any sense in this" right out of the gate. Explaining basic physics is not bad manners. Calling someone a "meatproxy" because you dislike normal engineering terms is.

You neglected to provide any supporting materials to support your proposal. This would be a non-starter even before the age of AI. There were no logs or anything of substantive nature to demonstrate the change has benefits in a context that extends to more than just yourself and your specific operational circumstances. Merely showing that the code compiles does and the boolean gets fiddled via API call does not constitute adequate testing in any setting. You're introducing an option that affects guiding methodologies and performance and may have unintended ramifications or effect on systems other than your own, so it should have been obvious that you will need to supply evidence to back it up.

How you came across is that it seems you presumed your change would be unquestionably accepted with the paltry amount of information submitted with it, and are annoyed that you were asked to further explain it. Your response was to throw an agent-generated word salad back in the face of the requestor, as if you were annoyed at being asked to do so. It's not a genuine act, to start, and it's seen as disrespectful. Bruce asked for your explanation, not an LLM's. Bruce could have just prompted any AI himself if he wanted an AI-based breakdown of the change. But he asked for yours. That's not gatekeeping. It's his project after all and he has to answer for everything that goes into it.

Then there's your rather unprofessional personal mocking at the end. It's good that you're here under an alias rather than presenting in any professional capacity. Speaking of which, since you claim to work in the research space, it would be good to supply your account with your ORCiD code.

As for, Meatproxy, it's now part of the engineering lexicon and is wholly descriptive of a process. Recruiters even use it now, usually to explain what they're not looking for.

@daleghent Let me address your points one by one and wrap this up:

  1. Understanding the physics and writing an essay in a second language are two different things. Using an AI tool to polish phrasing when English is not my first language is completely normal, not a crime. If you believe me that I am a "meatproxy", I should setup a bot instead of constructing and typing words to reply to you.

  2. Missing RPC docs or Wiki updates can easily be added during a normal review. Rejecting a feature out of hand with "I don't see any sense in this" before any actual discussion is NOT how review works. I don't have any chance to start a discussion after I posting a reply so called "meatproxy". I never expected unconditional acceptance of my PR. I expected a technical discussion.

  3. Please define "development etiquette" when one side dismisses valid instrument requirements on sight and the other gets called a "meatproxy" for explaining them.

  4. Institutions use ROR IDs, not ORCIDs. I spent several years working in the industry and maintaining meter-class telescopes on-site before going back to grad school to focus on astronomical instrumentation. I do not need to hand out personal IDs just to prove I know how real telescopes work.

It is pretty funny watching someone preach about opensource "etiquette" while demanding personal real world info on a closed GitHub PR just to satisfy their curiosity. Whatever happened to respecting privacy? Especially when you still have not addressed a single technical point about slit photon loss, decoupled headless architecture, or why a one-shot optional RPC flag needs a video recording when I already have full SIL simulation results. I have said everything I need to say.

Finally, I don't want to keep arguing with you about how to be polite or your HR style words. Now I just feel that amateur astronomy (like those using NINA) and serious astronomy are two different things, especially when talking to someone who does not understand spectroscopy requirements. Terms like slit, IFU, random error and systematic error are basic concepts in astronomical instrumentation. Anyway, I am open to technical discussions, not your political correctness.

@daleghent

daleghent commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

@daleghent Let me address your points one by one and wrap this up:

  1. Understanding the physics and writing an essay in a second language are two different things. Using an AI tool to polish phrasing when English is not my first language is completely normal, not a crime. If you believe me that I am a "meatproxy", I should setup a bot instead of constructing and typing words to reply to you.
  2. Missing RPC docs or Wiki updates can easily be added during a normal review. Rejecting a feature out of hand with "I don't see any sense in this" before any actual discussion is NOT how review works. I don't have any chance to start a discussion after I posting a reply so called "meatproxy". I never expected unconditional acceptance of my PR. I expected a technical discussion.

The saying goes, "On the Internet, nobody knows you're a dog." Which is to say that the veil of anonymity can be a double-edged sword. Given the lack of any other clues and given the context of the current times, something that presents itself like an AI agent and talks like an AI agent can be easily assumed to be an AI agent. And if someone in the flesh is being asked to engage in an unsolicited conversation, it's still pretty safe to assume that they are expecting to have it with something that plausibly passes as another real person and not some automata. Whether you just copying+pasted your responses from an agent or actually wrote it out with "AI polish" done afterwards, is an aspect that is neither here nor there. Google Translate works just as well now as it did before Claude.

Documentation helps explain a feature in more plain terms and submitting it contemporaneously ensures it's not forgotten about and leaving it up to someone else to figure out and (hopefully) correctly document when it's realized to be missing. As far as PHD2 contributions go, I've done that myself in furnishing both new API functions and the documentation for them. It shows you're aware of what's required to help ensure the success of your contribution for users and that you're more invested things and not just trying to slam your own code in.

  1. Please define "development etiquette" when one side dismisses valid instrument requirements on sight and the other gets called a "meatproxy" for explaining them.

No, you don't get to hide behind this. The open mockery and outright personal attack you exhibited in your response to Bruce had all the echoes of a disappointed adolescent who is unaware of how they present themselves, not of a working professional. It was pretty vicious. I normally would have passed over this kind of PR discourse but your comment alone made me stop to register my disappointment. You don't seem to think it warrants any apology or contrition, so I made sure to quote you on it so that it sticks around. It sure doesn't help your case and deflecting won't work.

  1. Institutions use ROR IDs, not ORCIDs. I spent several years working in the industry and maintaining meter-class telescopes on-site before going back to grad school to focus on astronomical instrumentation. I do not need to hand out personal IDs just to prove I know how real telescopes work.

I never mentioned ROR ID, which is completely different than an ORCID. You ought to know that RORs identify institutions and ORCiDs identify individuals. An ORCiD is required for each author that participates in research that is sponsored by any major national and EU research funding arm, as well as thousands of journals in order to submit. If you don't have one now, you will certainly find yourself needing one in the future - especially if you reference your own code in a paper. GitHub enables one to be associated with one's account.

It is pretty funny watching someone preach about opensource "etiquette" while demanding personal real world info on a closed GitHub PR just to satisfy their curiosity. Whatever happened to respecting privacy? Especially when you still have not addressed a single technical point about slit photon loss, decoupled headless architecture, or why a one-shot optional RPC flag needs a video recording when I already have full SIL simulation results. I have said everything I need to say.

You can engage in all these things, but if you're doing it through a proxy, people who you're trying to get the attention of will tend to want to know who or what they're dealing with. If it talks like AI and doesn't look like a real human, it likely is an AI. This is something you should understand in an age were open source developers in particular often find themselves dealing with PRs and issues being opened by Agents with no known provenance, affiliation, or (in some cases) clear motive.

  • Any experienced developer should be able to recognize when their change is trivial or not.
  • Any experienced developer would recognize the need to prepare supporting materials, tests, and their results when it comes to advocating for fundamental changes to core concepts in any application, PHD2 included. The fact that this is guarded by an on/off switch doesn't change that.
  • Your change that affects 18+ files in order to accommodate it should have been a sign to you as to how extensively it affects core methods.
  • Any developer can recognize that simulators tend to simulate "sunny day" and otherwise perfect conditions. Sometimes this is sufficient for a given change and, often enough, it is not. Given what MinMove affects and how pulseguide behaviors and latencies are implemented across the menagerie of mounts out there under different and often non-optimal conditions, I would say some more exhaustive proof is warranted.

What Bruce (and everyone else) wants to understand is why you think your method of attacking the problem is universally viable, with demonstrative proof beyond closed-environment simulations. Saying that the code compiles and the simulators seem ok with it just says to the observer that the code has never left your desktop and has not been used in real-world situations, let alone across an acceptably diverse population of mounts. A change like this has to work for more people than just "Atlas8m on some unknown telescope".

Finally, I don't want to keep arguing with you about how to be polite or your HR style words. Now I just feel that amateur astronomy (like those using NINA) and serious astronomy are two different things, especially when talking to someone who does not understand spectroscopy requirements. Terms like slit, IFU, random error and systematic error are basic concepts in astronomical instrumentation. Anyway, I am open to technical discussions, not your political correctness.

I, personally, understand all these things. I'm part of a team that does speckle interferometry on the 100" and 60" telescopes at Mt. Wilson - storied instruments, as you might know. Getting a fibre-fed spectroscope added to our existing instrument package is one of our upcoming goals so that we can also measure radial velocity in addition to the theta and rho of the subordinate star. This is so we can start filling in data on double stars that even Gaia was not able to resolve, which can include placing the secondary on the H-R diagram. A tough problem to solve for us is that the control systems for these telescopes are electric with encoders but manually directed, so we have to devise a secondary mechanical system to position target double star beyond what the telescope's own fine movement gears are able to perform. So, yes, I actually do understand spectroscopy requirements.

Consider putting a check on the hot-shot attitude you're displaying because you might not be fully aware of the company you're in, or who else might be silently watching here. I understand you recognize me as being affiliated with NINA and you're wasting no opportunity to get an amateur vs. professional dig in on that as well. We're also running our speckle sessions using NINA, just so you're aware. If you want to exude an aura of professionalism, you're doing everything but that.

@Atlas8m

Atlas8m commented Nov 17, 2026

Copy link
Copy Markdown
Author

@daleghent Let me address your points one by one and wrap this up:

  1. Understanding the physics and writing an essay in a second language are two different things. Using an AI tool to polish phrasing when English is not my first language is completely normal, not a crime. If you believe me that I am a "meatproxy", I should setup a bot instead of constructing and typing words to reply to you.
  2. Missing RPC docs or Wiki updates can easily be added during a normal review. Rejecting a feature out of hand with "I don't see any sense in this" before any actual discussion is NOT how review works. I don't have any chance to start a discussion after I posting a reply so called "meatproxy". I never expected unconditional acceptance of my PR. I expected a technical discussion.

The saying goes, "On the Internet, nobody knows you're a dog." Which is to say that the veil of anonymity can be a double-edged sword. Given the lack of any other clues and given the context of the current times, something that presents itself like an AI agent and talks like an AI agent can be easily assumed to be an AI agent. And if someone in the flesh is being asked to engage in an unsolicited conversation, it's still pretty safe to assume that they are expecting to have it with something that plausibly passes as another real person and not some automata. Whether you just copying+pasted your responses from an agent or actually wrote it out with "AI polish" done afterwards, is an aspect that is neither here nor there. Google Translate works just as well now as it did before Claude.

Documentation helps explain a feature in more plain terms and submitting it contemporaneously ensures it's not forgotten about and leaving it up to someone else to figure out and (hopefully) correctly document when it's realized to be missing. As far as PHD2 contributions go, I've done that myself in furnishing both new API functions and the documentation for them. It shows you're aware of what's required to help ensure the success of your contribution for users and that you're more invested things and not just trying to slam your own code in.

  1. Please define "development etiquette" when one side dismisses valid instrument requirements on sight and the other gets called a "meatproxy" for explaining them.

No, you don't get to hide behind this. The open mockery and outright personal attack you exhibited in your response to Bruce had all the echoes of a disappointed adolescent who is unaware of how they present themselves, not of a working professional. It was pretty vicious. I normally would have passed over this kind of PR discourse but your comment alone made me stop to register my disappointment. You don't seem to think it warrants any apology or contrition, so I made sure to quote you on it so that it sticks around. It sure doesn't help your case and deflecting won't work.

  1. Institutions use ROR IDs, not ORCIDs. I spent several years working in the industry and maintaining meter-class telescopes on-site before going back to grad school to focus on astronomical instrumentation. I do not need to hand out personal IDs just to prove I know how real telescopes work.

I never mentioned ROR ID, which is completely different than an ORCID. You ought to know that RORs identify institutions and ORCiDs identify individuals. An ORCiD is required for each author that participates in research that is sponsored by any major national and EU research funding arm, as well as thousands of journals in order to submit. If you don't have one now, you will certainly find yourself needing one in the future - especially if you reference your own code in a paper. GitHub enables one to be associated with one's account.

It is pretty funny watching someone preach about opensource "etiquette" while demanding personal real world info on a closed GitHub PR just to satisfy their curiosity. Whatever happened to respecting privacy? Especially when you still have not addressed a single technical point about slit photon loss, decoupled headless architecture, or why a one-shot optional RPC flag needs a video recording when I already have full SIL simulation results. I have said everything I need to say.

You can engage in all these things, but if you're doing it through a proxy, people who you're trying to get the attention of will tend to want to know who or what they're dealing with. If it talks like AI and doesn't look like a real human, it likely is an AI. This is something you should understand in an age were open source developers in particular often find themselves dealing with PRs and issues being opened by Agents with no known provenance, affiliation, or (in some cases) clear motive.

  • Any experienced developer should be able to recognize when their change is trivial or not.
  • Any experienced developer would recognize the need to prepare supporting materials, tests, and their results when it comes to advocating for fundamental changes to core concepts in any application, PHD2 included. The fact that this is guarded by an on/off switch doesn't change that.
  • Your change that affects 18+ files in order to accommodate it should have been a sign to you as to how extensively it affects core methods.
  • Any developer can recognize that simulators tend to simulate "sunny day" and otherwise perfect conditions. Sometimes this is sufficient for a given change and, often enough, it is not. Given what MinMove affects and how pulseguide behaviors and latencies are implemented across the menagerie of mounts out there under different and often non-optimal conditions, I would say some more exhaustive proof is warranted.

What Bruce (and everyone else) wants to understand is why you think your method of attacking the problem is universally viable, with demonstrative proof beyond closed-environment simulations. Saying that the code compiles and the simulators seem ok with it just says to the observer that the code has never left your desktop and has not been used in real-world situations, let alone across an acceptably diverse population of mounts. A change like this has to work for more people than just "Atlas8m on some unknown telescope".

Finally, I don't want to keep arguing with you about how to be polite or your HR style words. Now I just feel that amateur astronomy (like those using NINA) and serious astronomy are two different things, especially when talking to someone who does not understand spectroscopy requirements. Terms like slit, IFU, random error and systematic error are basic concepts in astronomical instrumentation. Anyway, I am open to technical discussions, not your political correctness.

I, personally, understand all these things. I'm part of a team that does speckle interferometry on the 100" and 60" telescopes at Mt. Wilson - storied instruments, as you might know. Getting a fibre-fed spectroscope added to our existing instrument package is one of our upcoming goals so that we can also measure radial velocity in addition to the theta and rho of the subordinate star. This is so we can start filling in data on double stars that even Gaia was not able to resolve, which can include placing the secondary on the H-R diagram. A tough problem to solve for us is that the control systems for these telescopes are electric with encoders but manually directed, so we have to devise a secondary mechanical system to position target double star beyond what the telescope's own fine movement gears are able to perform. So, yes, I actually do understand spectroscopy requirements.

Consider putting a check on the hot-shot attitude you're displaying because you might not be fully aware of the company you're in, or who else might be silently watching here. I understand you recognize me as being affiliated with NINA and you're wasting no opportunity to get an amateur vs. professional dig in on that as well. We're also running our speckle sessions using NINA, just so you're aware. If you want to exude an aura of professionalism, you're doing everything but that.

@daleghent

As an engineer, you don't even understand basic mutual respect. Look back at the thread and ask yourself who started demeaning the other side and provoked this whole argument in the first place, dismissing a valid requirement on sight and calling me a meatproxy before any real discussion even began. Funny how you complain about personal attacks right after taking cheap shots with a nobody knows you're a dog quote and calling me a disappointed adolescent in the exact same post. That is some impressive double standards, just like western politicians.

You wrote four long paragraphs about ORCIDs, Mt. Wilson, and veiled threats about who is silently watching, yet you still dodged the only physics question on the table: how MinMove deadbands hurt slit/IFU spectroscopy. Frankly, I don't care who is watching at me, I'm an instrumentation grad student, my advisor knows all about this, and I have no interest in playing status games in your circle.

Doing millisecond speckle interferometry on a 100 year old mount with NINA is completely different from continuous closed loop guiding. One takes short lucky imaging exposures, the other holds a target inside an IFU for 15 minutes or longer, requiring no deadband drift, and, has to do it fully automatically across a large scale high resolution spectroscopic survey.

The PR is closed, keep your legacy code, and I'm done wasting time here. If you want to keep arguing instead of having a constructive discussion about instrumentation, maybe pointing a bot at this thread really would be a better use of my time. Anyway, I have my own custom RC mirror set to fix and mount, an echelle spectrograph to build, and direct-drive mount control boards and firmware to finish, wasting time on this just ruins my mood. You owe me 20000 bucks for all the engineering time you've wasted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants