Repository navigation
Export "needs review" flag to KiCad HTTP library - #1590
Merged
jbtronics merged 1 commit intoOct 10, 2026
Merged
Conversation
Add a "Part-DB Needs Review" field to the KiCad part export when the part is flagged for review. The field belongs to the existing part info field group, so it follows the EDA_KICAD_EXPORT_PART_INFO_FIELDS setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Looks good. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export the part "needs review" flag to the KiCad HTTP library as a
Part-DB Needs Reviewfield.What changed
KiCadHelper::getKiCADPart()adds aPart-DB Needs Reviewfield with valueYeswhen the part is flagged for reviewEDA_KICAD_EXPORT_PART_INFO_FIELDS)KiCadApiControllerTestBehavior
Why this approach
It reuses the existing part info setting and the pattern of the neighbouring fields, so there is no new setting, translation or migration. Only exporting the field when it is set avoids adding a field to every part and avoids new ERC warnings in existing schematics.
Verification
tests/Controller/KiCadApiControllerTest.phpandtests/Services/EDA/KiCadHelperTest.php(45 tests passing)KiCadHelper.php🤖 Generated with Claude Code