Skip to content

Export "needs review" flag to KiCad HTTP library - #1590

Merged
jbtronics merged 1 commit into
Part-DB:masterfrom
Dant-hw:feature/kicad-export-needs-review
Oct 10, 2026
Merged

jbtronics merged 1 commit into
Part-DB:masterfrom
Dant-hw:feature/kicad-export-needs-review

Conversation

@Dant-hw

@Dant-hw Dant-hw commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Export the part "needs review" flag to the KiCad HTTP library as a Part-DB Needs Review field.

What changed

  • KiCadHelper::getKiCADPart() adds a Part-DB Needs Review field with value Yes when the part is flagged for review
  • The field belongs to the existing part info field group (EDA_KICAD_EXPORT_PART_INFO_FIELDS)
  • Updated the docs table and the expected output in KiCadApiControllerTest

Behavior

  • Parts that do not need review export exactly the same fields as before
  • When the flag is set, the field appears in KiCad, so it can be seen on the symbol properties and used in BOMs
  • When the flag is cleared later, KiCad's ERC reports a library mismatch on placed symbols, which shows the review is done

Why this approach

It reuses the existing part info setting and the pattern of the neighbouring fields, so there is no new setting, translation or migration. Only exporting the field when it is set avoids adding a field to every part and avoids new ERC warnings in existing schematics.

Verification

  • Ran tests/Controller/KiCadApiControllerTest.php and tests/Services/EDA/KiCadHelperTest.php (45 tests passing)
  • PHPStan reports no errors on KiCadHelper.php

🤖 Generated with Claude Code

Add a "Part-DB Needs Review" field to the KiCad part export when the
part is flagged for review. The field belongs to the existing part info
field group, so it follows the EDA_KICAD_EXPORT_PART_INFO_FIELDS setting.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jbtronics

Copy link
Copy Markdown
Member

Looks good. Thank you.

@jbtronics
jbtronics merged commit 20f9a70 into Part-DB:master Oct 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants