Use client ID and document setup pitfalls - #9
Merged
Merged
Conversation
The create-github-app-token action deprecated `app-id` in favor of `client-id`, which logged a warning on every run. Also record two setup steps that were easy to miss: the Projects permission has identically named entries under Organization and Repository, and creating the app does not install it.
The caller job needs no GITHUB_TOKEN scopes; all work uses the app token minted inside the reusable workflow. Stating permissions explicitly avoids inheriting whatever the repository default is.
slifty
force-pushed
the
noissue-use-client-id
branch
from
July 27, 2026 20:10
721a0f9 to
16cdf12
Compare
There was a problem hiding this comment.
Pull request overview
Updates the reusable “Add to project” workflow and its onboarding docs to align with actions/create-github-app-token’s app-id deprecation and to document common setup/tagging pitfalls for rolling the v1 tag.
Changes:
- Switch
actions/create-github-app-tokeninput fromapp-idtoclient-id(PDC_BOT_CLIENT_ID). - Harden the caller workflow template (and documented example) by explicitly setting
permissions: {}. - Expand README guidance around app installation/permissions, verifying granted permissions via
gh api, and saferv1tag publishing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
workflow-templates/add-to-project.yml |
Adds permissions: {} to the template caller workflow before invoking the reusable workflow. |
.github/workflows/README.md |
Documents PDC_BOT_CLIENT_ID, setup pitfalls (org vs repo Projects permission, app installation), verification snippet, and safer v1 tagging guidance. |
.github/workflows/add-to-project.yml |
Replaces deprecated app-id usage with client-id for app token generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7, from setting the workflow up for real against
auth.app-id→client-id.actions/create-github-app-tokendeprecatedapp-id; every run loggedInput 'app-id' has been deprecated with message: Use 'client-id' instead.v1tag moves.PDC_BOT_CLIENT_IDmust be set (theIv23...Client ID from the pdc-bot app page, not the numeric App ID) or every caller breaks. Order: set the variable → merge → movev1.PDC_BOT_APP_IDcan be deleted afterward.README fixes:
git tag -f v1 origin/mainrather thanmain, so a stale local checkout can't publish the wrong commit under a force-pushed tag.v1— releases can be marked immutable, which would permanently prevent the tag from moving and break the whole rollout model.gh apisnippet to verify what the installation was actually granted.🤖 Generated with Claude Code
https://claude.ai/code/session_01V72EH61bzDFnGMcnEfvnZY