Skip to content

Sender::sendMessage() incorrectly sets DataHeader::unscheduledIndexLimit  #7

Description

@cstlee

The documentation states that the DataHeader::unscheduledIndexLimit is the number of packets that "will be sent" without a grant. However, Sender::sendMessage() sets this value to be the max number of packets that "might" be sent. This mismatch can lead the Receiver to expect more unscheduled packets than there are packets in the message which in turn may cause RESEND requests for nonexistent packets. The current implementation ignores these "inconsistent" RESEND request with a warning message and thus the issue doesn't result in an application visible error.

The implementation should be fixed so that both the Sender and Receiver use a consistent definition of unscheduledIndexLimit.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions