Repository navigation
Apply the CommonMark rule of 3 which we missed. - #1691
Merged
Merged
Conversation
Rule of 3: an ambiguous delimiter cannot pair with an open delimiter if the sum of the original lengths is a multiple of 3 (unless both are multiples of 3). 3 existing test were changed. These matched the results of other CommonMark parsers but not the official CommonMark implementation. These other parsers missed a subtle interpretation of the rule of 3 that the official implementation applies. Fixes Python-Markdown#1690
waylan
approved these changes
Nov 5, 2026
8 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule of 3: an ambiguous delimiter cannot pair with an open delimiter if the sum of the original lengths is a multiple of 3 (unless both are multiples of 3).
3 existing test were changed. These matched the results of other CommonMark parsers but not the official CommonMark implementation. These other parsers missed a subtle interpretation of the rule of 3 that the official implementation applies.
AI was used to pin down where we deviated and generate the tests to capture where we deviated.
It particualry was particularly useful to identify why some CommonMark parsers don't match the
official one with certain applications of the "rule-of-3".
Fixes #1690
Description
AI Assistance Disclosure
No AI tools were used in preparing this PR.
AI tools were used and I have disclosed which ones, and have fully reviewed and verified their output.
AI tools were use to assist with the following:
Checklist