[miri64]

Contribution description

Another contribution to #22944

Provide tests for all currently untested ShellInteraction subclasses in riotctrl_shell to prevent future bitrot [...]

Testing procedure

The provided test should pass.

Issues/PRs references

Fixes parts of #22944.

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

• none

[riot-ci]

Murdock results

✔️ PASSED

9fed264 tests: Add tests for riotctrl_shell.loramac

Success	Failures	Total	Runtime
14097	0	14097	11m:39s

Artifacts

• Documentation preview

[Stopkaa]

Tried to test it with a nucleo-wl55jc and get some linkage error since the test doesn't pull shell_cmds_default and instead pull shell_cmd_semtech-loramac directly which doesn't add fmt. Also there was a missuse of USEMODULE/USEPKG(this one found by Claude). This fixes it for me:

diff --git a/sys/shell/Makefile.dep b/sys/shell/Makefile.dep
index 91fda88b40..d72851eaf3 100644
--- a/sys/shell/Makefile.dep
+++ b/sys/shell/Makefile.dep
@@ -110,7 +110,6 @@ ifneq (,$(filter shell_cmds_default,$(USEMODULE)))
   endif
   ifneq (,$(filter semtech-loramac,$(USEPKG)))
     USEMODULE += shell_cmd_semtech-loramac
-    USEMODULE += fmt
   endif
   ifneq (,$(filter sntp,$(USEMODULE)))
     USEMODULE += shell_cmd_sntp
@@ -293,8 +292,9 @@ endif
 ifneq (,$(filter shell_cmd_saul_reg,$(USEMODULE)))
   USEMODULE += saul_reg
 endif
-ifneq (,$(filter shell_cmd_semtech-loramac,$(USEPKG)))
-  USEMODULE += semtech-loramac
+ifneq (,$(filter shell_cmd_semtech-loramac,$(USEMODULE)))
+  USEPKG += semtech-loramac
+  USEMODULE += fmt
 endif
 ifneq (,$(filter shell_cmd_sha1sum,$(USEMODULE)))
   USEMODULE += shell_cmd_vfs

[miri64]

Tried to test it with a nucleo-wl55jc and get some linkage error since the test doesn't pull shell_cmds_default and instead pull shell_cmd_semtech-loramac directly which doesn't add fmt. Also there was a missuse of USEMODULE/USEPKG(this one found by Claude). This fixes it for me:

diff --git a/sys/shell/Makefile.dep b/sys/shell/Makefile.dep
index 91fda88b40..d72851eaf3 100644
--- a/sys/shell/Makefile.dep
+++ b/sys/shell/Makefile.dep
@@ -110,7 +110,6 @@ ifneq (,$(filter shell_cmds_default,$(USEMODULE)))
   endif
   ifneq (,$(filter semtech-loramac,$(USEPKG)))
     USEMODULE += shell_cmd_semtech-loramac
-    USEMODULE += fmt
   endif
   ifneq (,$(filter sntp,$(USEMODULE)))
     USEMODULE += shell_cmd_sntp
@@ -293,8 +292,9 @@ endif
 ifneq (,$(filter shell_cmd_saul_reg,$(USEMODULE)))
   USEMODULE += saul_reg
 endif
-ifneq (,$(filter shell_cmd_semtech-loramac,$(USEPKG)))
-  USEMODULE += semtech-loramac
+ifneq (,$(filter shell_cmd_semtech-loramac,$(USEMODULE)))
+  USEPKG += semtech-loramac
+  USEMODULE += fmt
 endif
 ifneq (,$(filter shell_cmd_sha1sum,$(USEMODULE)))
   USEMODULE += shell_cmd_vfs

I remember that there was an issue with some boards when doing the dependencies like this (and yes, I also noticed the USEMODULE/USEPKG discrepency but thought they were aliased)... But I can try.

[miri64]

But I can try.

Murdock saw no issue.

[miri64]

Rebased to current master to resolve conflicts caused by the merging of #23051.

[miri64]

And squashed

[mguetschow]

LGTM then! Since Murdock runs fine, this should be good to go.

[miri64]

While testing the build in #23067, I noticed that the ESP32 problem might actually be related to my local environment and not due to the mocking of periph_eeprom. Will investigate.

[miri64]

Yepp, because I got an error about cpu/esp32/vendor/ld/esp32s3/memory.ld.in I assumed it had something to do with the eeprom, but turns out: I just had a stale version of esp32_sdk in by build/pkg 😅

[miri64]

Thanks for all the reviews!