Repository navigation
Conversation
Contributor
Author
|
History (distribution-old hashes):
On all these boards the button printed A is BTN_EAST (b1): mainline rk3566-anbernic-rg353x.dtsi and rk3566-powkiddy-rk2023.dtsi have button-a = GPIO3_C2 = BTN_EAST, the same as our trees. |
qzydustin
force-pushed
the
builtin-pad-labels
branch
from
October 8, 2026 06:32
0b0835f to
d4d7008
Compare
1 of 3 tasks
qzydustin
force-pushed
the
builtin-pad-labels
branch
from
October 9, 2026 01:58
d4d7008 to
6274d02
Compare
Contributor
Author
|
Split the commander change into its own PR; this one now only fixes the retrogame_joypad line. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do?
The
retrogame_joypadline in gamecontrollerdb maps A/B by position but X/Y by label (a:b0,b:b1,x:b2,y:b3), while es_input.cfg and every other built-in pad map all four by label. So on these devices Circle is on the bottom button in PPSSPP (RG351P/M, G350) and DuckStation, and the GameCube X/Y are swapped in Dolphin.Revert the A/B change of c1fd2da (
a:b1,b:b0), drop the RK3566 PPSSPP Circle/Cross swap that made up for it, and swap it back in existing RK3566 controls.ini on update. With this, the retrogame_joypad devices map the same way as every other built-in pad, and RK3566 uses the same PPSSPP controls as the other platforms.Testing & Verification
Test Steps
Test Results & Evidence
Needs a tester. Most ports use /tmp/gamecontrollerdb.txt, which mapper.txt builds from es_input.cfg and the controller_layout setting, so they don't change (checked on an R36S clone); the Moonlight port and Ikemen read the system db directly and follow this change.
Additional Context & Reviewer Notes
History in the first comment.
AI Assistance Disclosure