Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do?
Changing the video filter in game with threaded video crashes RetroArch (Gameboy4x_Pocket), leaves a black screen (2xBR) or garbles the picture (ntsc_crt).
Backports three upstream fixes newer than our RetroArch:
They can be dropped at the next RetroArch bump.
Testing & Verification
Test Steps
Test Results & Evidence
Before: Gameboy4x_Pocket crashes (exit 139), 2xBR is black, ntsc_crt is garbled.
After: all filters apply without a crash; toggling and removing give the right picture. Toggling reinitialises video only for ntsc_crt.
Additional Context & Reviewer Notes
0013 and 0014 are upstream with offsets adjusted; 0014's new helper checks XRGB8888 only, as this version has no 10-bit formats. 0015 is the menu part only: the filter path setting is in menu_setting.c here, and the test harness is left out.
AI Assistance Disclosure
While ROCKNIX has no restrictions on using AI tools, transparency helps reviewers set the proper context during code review.
Did you use AI tools (e.g., ChatGPT, Copilot, Claude) to assist with this pull request?