Skip to content

X coordinates collision #1

Description

@gching

value = @util.random()

I know this codebase is pretty old, but it seems like there is a possibility of x coordinates colliding upon generating the points / parts at random.

As we do not insert a selected x coordinate for a point into numbers, another point's x coordinate can possibly collide.

Activity

  1. cipherboy commented on Mar 22, 2018

    @cipherboy
    Member

    Fair point, I do believe that's an oversight on our part. I probably won't fix it though -- the probability of it occurring is extraordinarily low considering the prime in question (115792089237316195423570985008687907853269984665640564039457584007913129639747) and a reasonable quantity of shares (< 2^16).

    If you want to file a PR, fine, but neither I or @Mab879 are currently using this. I'd also suggest the protocol should be changed before others use this, so I'm not sure its worth your time.

  2. gching commented on Mar 26, 2018

    @gching
    Author

    Makes sense 👍 was just researching up a lot of sss algorithms. Great clean code btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions