Support postgres:db_name URLs in sea-orm-cli entity generation - #3197
Merged
Merged
Conversation
`sea-orm-cli generate entity -u postgres:my_db` panicked with "There is no database name as part of the url path", although libpq accepts that form. A URL with no authority component is a cannot-be-a-base URL, so `Url::path_segments()` returns `None` and the old code turned that straight into a panic. Extract the lookup into `database_name_from_url`, which falls back to the whole path in that case, and unit test it across both URL shapes. Reported by @julienw in #2647; supersedes #2754 by @kev1N916. Closes #2647
🎉 Released In 2.0.3 🎉Huge thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #2754.