Repository navigation
rootfs: install the AYANEO 3 udev rule in the install target - #556
Merged
Merged
Conversation
70-ayaneo-modules.rules has been in the tree since ShadowBlip#536 but the install target never installs it, so make install (and packages built from it) ship without it. Add it to install/uninstall, matching the systemd user unit pattern, so the AYANEO 3 plugin's eject/reset/controller_power sysfs attributes are writable out of the box.
pastaq
approved these changes
Oct 2, 2026
ShadowApex
requested changes
Oct 6, 2026
ShadowApex
left a comment
Collaborator
There was a problem hiding this comment.
The RPM build is currently failing with this change:
https://github.com/ShadowBlip/OpenGamepadUI/actions/runs/36744549618/job/111245124550#step:3:10071
Once you update the RPM spec with this new file, the build should pass.
Contributor
Author
|
Thanks — fixed in 83b67b8. The spec's |
ShadowApex
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rootfs/usr/lib/udev/rules.d/70-ayaneo-modules.ruleshas been in the treesince #536, but
rootfs/Makefile'sinstalltarget never installs it, somake installdoesn't place it under$(PREFIX)/lib/udev/rules.d/. Everyother file in
rootfs/is installed by that target; this one was missed.The practical effect: distro packages built via
make install(Bazzite'sTerra package among them) ship OpenGamepadUI without the rule, so the AYANEO
3 plugin's
eject/reset/controller_powersysfs attributes stayroot-only and the plugin can't perform a module eject without the user
dropping the rule into
/etc/udev/rules.d/by hand. With the rule installed(to
/usr/lib/udev/rules.d/whenPREFIX=/usr) eject works out of the box.This adds the rule to the
installtarget (and removes it inuninstall),following the same
install -Dm644 … $(PREFIX)/lib/…pattern as the systemduser units directly above it.
Verified that the install line lands the rule at
$(PREFIX)/lib/udev/rules.d/70-ayaneo-modules.rules(i.e./usr/lib/udev/rules.d/…for a system install).Note for packagers: the file now reaches the build root, but a spec/recipe
that enumerates
%filesexplicitly (rather than globbing the install tree)will also need to list the new path to include it in the package.