Fix Utils.inspect and Utils.to_s to allow zero arguments - #2116
Open
shivaansh74 wants to merge 1 commit into
Open
Fix Utils.inspect and Utils.to_s to allow zero arguments#2116shivaansh74 wants to merge 1 commit into
shivaansh74 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2107
Problem
Calling
Liquid::Utils.inspectorLiquid::Utils.to_swithout arguments raised anArgumentErrorinstead of delegating tosuper(the default module inspect/to_s representation).Solution
Liquid::Utils.inspectandLiquid::Utils.to_sto accept variable arguments (*args).super, returning the module name representation.test/unit/utils_unit_test.rbto verify zero-argument and object-argument behaviors.