Repository navigation
Minimum version of Eigen #19
Description
Following the README for installation of Eigen:
"the Eigen C++ template library - conda-forge | repo",
it comes that the suggested version is 3.4.
Moreover, we have guards on version 3.3, e.g.:
#if EIGEN_VERSION_AT_LEAST(3, 3, 90)
.def(
"rankUpdate",
[](Chol &c, const VectorType &w, Scalar sigma) -> Chol & {
return c.rankUpdate(w, sigma);
},
"If LL^* = A, then it becomes A + sigma * v v^*", "w"_a, "sigma"_a,
nb::rv_policy::reference)
#elseThen should we remove them ?
Activity
ManifoldFR commentedon Jul 25, 2025
Probably yes, since Ubuntu 20.04 (and with it Eigen 3.3.7, the last 3.3.x release) are end-of-life
Do you concur @jorisv @nim65s ?
nim65s commentedon Jul 27, 2025
lgtm
ahoarau commentedon Jan 10, 2026
@ManifoldFR @nim65s can we close this one ?