Repository navigation
Check the plugin file count in the Check workflow - #9
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow computes its reported largest file after excluding images and fonts, so it can misidentify the largest tracked file when an exempt asset is actually larger.
1 open issue
What changed in this PR
Updates the release checks to enforce the plugin directory’s tracked-file and size limits, with corresponding release documentation.
Changes:
- Adds a 512-file limit for tracked repository files.
- Exempts common font formats, alongside images, from the 256 KiB limit.
- Logs file-count and largest-file information during each check.
- Documents the updated limits and workflow diagnostics.
| File | Description |
|---|---|
| RELEASING.md | Documents the tracked-file limit, expanded font and image size exemptions, and workflow diagnostics. |
| .github/workflows/check.yml | Adds tracked-file counting, font exemptions, size validation, and largest-file diagnostics to the directory-limit check. |
Review effort: Lite
anna-dolbina
left a comment
There was a problem hiding this comment.
Verdict: approve.
The step now enforces the 512-file limit on the whole repository, which is right because both marketplaces use source: "./". It also exempts fonts in line with the generator and logs useful headroom figures on every run. I found nothing blocking; the inline comments are nits, and only the log wording is worth fixing before merge.
What works well
sizesis computed once and drives both the size check and the log, and over-limit files are now listed largest first.- File names with spaces, tabs and non-ASCII characters are handled. I checked
${largest#* }and thegit ls-filescount with such names. - RELEASING.md matches the code, including the 400-file skill budget (
MaxSkillFiles = 400in the generator).
Findings (all nits)
check.yml:95-97: the log calls a file over 256 KiB "under the 256 KiB limit". Reuse RELEASING.md's wording, "the largest file that the 256 KiB limit applies to". There's a suggestion inline.check.yml:94(optional): ifsizeswere ever empty, the log line would print a bash arithmetic error. The step result would still be correct. Guarding withxargs -rand[ -n "$largest" ]would keep the log clean.check.yml:79(optional): add a remedy to the error, as the generator and the version step do.
The exempt-extension list (woff2?|ttf|otf) follows the generator's comment ("other than an image or font"), but I couldn't confirm the exact list against the directory's own rules. That's low risk, since the repository has no fonts today.
Generated by Claude Code
Co-authored-by: Anna Dolbina <1564418+anna-dolbina@users.noreply.github.com>

Issue: https://github.com/TeamDev-IP/DotNetBrowser/issues/4148
Proposed changes
Anthropic's plugin directory holds a plugin with more than 512 files for a reviewer instead of publishing it. The skill generator keeps the skill within 400 files (TeamDev-IP/DotNetBrowser#4149), but the Check workflow didn't count files.
The "Check directory limits" step now:
RELEASING.mddescribes the new check.Validation
Run locally: the step passes on
main(263 files) and fails with both errors when the limits are lowered below the current repository.