Corgi unit value diversion - #870
Open
frankmcsherry wants to merge 3 commits into
Open
Conversation
Use unit_output() for output handling and resolves_input_payloads() for the current input resolution path. Count remains on that general path; a later diff-only implementation can opt out without changing presentation. Register PresentedIds through the existing value registration helper, restore the negative-weight rationale, assert bracket lengths, and rename the unit-value test module without changing its oracle tests. For context, four-process maintenance medians for diversion 566e753 against master-next 626c80c were Reach 100.03 -> 91.18 ms/epoch (-8.8%), pair-key Reach 120.35 -> 111.34 (-7.5%), and SCC 530.92 -> 531.08 (within run spread). Apple M4, one worker, mimalloc, release/LTO, averaging epochs 6-25; Reach 200k nodes/400k edges, SCC 100k/200k, 1k replacements/epoch. These measure the entire diversion, not inserts/gather in isolation, and predate this helper/comment cleanup. Compound input hashes remain; unit IDs, resolution pools, correction maps and output indices are avoided. Validation: 133 selected Rust tests passed, 2 existing ignores; git diff --check passed. Count's existing positive-only semantics are unchanged in both DDIR backends, despite differing from signed DD count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Divert computation in a reduce whose values are
UNIT, as would be the case in a distinct operator, or similar.