Adapt to timely #817: least()/retain_least(), inspect_core, Collection::delay - #874
Open
frankmcsherry wants to merge 3 commits into
Open
Adapt to timely #817: least()/retain_least(), inspect_core, Collection::delay#874frankmcsherry wants to merge 3 commits into
frankmcsherry wants to merge 3 commits into
Conversation
- Collection::inspect_batch / inspect_container: T: TotalOrder (they reveal one time). - capture.rs CDC progress operator: hold a CapabilitySet via retain_stamp. - dogsdogsdogs half_join: insert each element of retain_stamp. - tests: dynamic.rs asserts stamp().len() == 1 explicitly; wcoj_partial_order uses inspect. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012k2GSwxmvD2LvckkoXi6GK
…delay_batch upsert and the diagnostics loggers take the time if present and drop the message otherwise. Collection::delay no longer uses timely's delay_batch (now TotalOrder bounded): it delays each stamp element and each update's time by func and sends immediately under the delayed capability set, which works for partial orders. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012k2GSwxmvD2LvckkoXi6GK
…y_notify is gone Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012k2GSwxmvD2LvckkoXi6GK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches differential-dataflow up to timely #817 (
InputCapability::time()requiresTotalOrderand returnsOption;retainisretain_least;for_each_timeisfor_each_stamp; inspect isinspect_core+inspect). Stacked on #855, whoseretain_stampadaptations this builds on; base isdd-dynamic-stampsso the diff is only these changes.Collection::inspect_batchhands the closure the batch'sStamp<T>rather than a time, andCollection::inspect_containerisinspect_core, both without bounds.Collection::delayno longer uses timely'sdelay_batch(bounded, then removed). DD keeps the time in the data, so it delays each stamp element and each update's time throughfuncand sends at once under the delayedCapabilitySet. Works for partial orders; the spuriousT: Hashbound is gone.CapabilitySetfromretain_stamp; upsert takesretain_leastif present; the diagnostics loggers takeleast()if present, dropping a message with no capabilities.half_joininserts each element ofretain_stamp.inspect.Workspace tests pass against timely master at 11beaae3 (the
Cargo.lockis not tracked, so the git dependency floats there on its own).🤖 Generated with Claude Code
https://claude.ai/code/session_012k2GSwxmvD2LvckkoXi6GK