Repository navigation
Add explicit dirty bit to pushers::Counter - #825
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #824
#824 observed a bug through an untested pattern of interactions that was definitely wrong. Adding an explicit dirty seems to be the right fix, leaving a few lingering questions about e.g. empty messages and whether they should dirty the bit, stuff like that. But the conservative approach, of flushing if there has been even a single
Somemessage, seems to fix things.Also adds a regression test, though it raises the point that better still would be a simulation harness, like #810, that is able to explore the interaction space better.