Repository navigation
Conversation
…e the menu While browsing Saved Peds or Saved Characters, the highlighted save stands beside the menu dressed as it would spawn, and stays there inside its own page. Q and E turn it. A new Miscellaneous Settings checkbox, 3D Ped Preview, turns it off, on by default. Added to both the Enhanced and the Legacy client, with the strings in every shipped language.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 3D preview of saved peds and saved characters beside the menu, so a save can be seen before it is spawned.
What it does
PedAppearanceWriterfor peds,FreemodeWriterwith the current style and outfit for characters).Menu.Width, aspect ratio), on whichever side of the menu has room, and follows the camera every frame.miscPedPreviewuser default.How it works
PedPreviewis a static class likePropPreview. A menu registers how to find the ped for its highlighted row, and one tick asks whichever menu is on screen: every 250 ms while nothing is shown, every frame while a ped is standing there. Asking rather than being told throughOnOpened/OnClosedis what keeps the same ped standing between a list and its detail page.The ped is local only (not networked), frozen, without collision, invincible, and hidden until it has been dressed and streamed in. It is removed when the menu changes, the pause menu opens, the setting is turned off, or the resource stops (
ResourceShutdown.Stopping). Saves from a newer build are skipped, like their spawn rows.Changes
Players/Appearance/PedPreview.cs, new, in both the Enhanced and the Legacy clientSavedPedsMenuandSavedCharactersregister their list and detail menus, and put the entry in each row'sItemDataMiscSettingsMenu,UserDefaults,Mainfor the setting and the tickLoc.MiscSettingsandEnglishStrings, translated inde,es,frandnl(coverage stays at 0 missing)All additions, nothing existing is changed.
Testing
dotnet build vMenu.Enhanced.slnx -c Releasebuilds with no new warningsLegacyChecks --verify-iland--check-refspass on the Legacy client