Repository navigation
Clarify average odds cancellation in metric explanations - #573
Open
Hanabi9248 wants to merge 4 commits into
Open
Hanabi9248 wants to merge 4 commits into
Hanabi9248 wants to merge 4 commits into
Conversation
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Hanabi9248
marked this pull request as ready for review
September 11, 2026 08:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #528.
Opposite-signed FPR and TPR differences can cancel: a four-row example returns average odds difference 0 while both average absolute odds difference and equalized odds difference are 1. Correct the two API docstrings and the text/JSON explanations so zero is no longer presented as sufficient for equality of odds. Metric formulas are unchanged.
The new explanation regression fails before the change. Local validation on Python 3.11:
The full optional-dependency Python/R suite has not been run locally. The GitHub Actions workflow is awaiting maintainer approval.