Add some more stream/future WAST tests for partial/zero reads/writes - #721
Merged
Merged
Conversation
dicej
approved these changes
Sep 14, 2026
dicej
left a comment
dicej
left a comment
Collaborator
There was a problem hiding this comment.
I'll work on fixing the failure in Wasmtime.
chenyan2002
pushed a commit
to chenyan2002/wasmtime
that referenced
this pull request
Sep 15, 2026
…ce#14340) This fixes the test failure described in WebAssembly/component-model#721, where a zero-length write following a cancelled non-zero-length write should return `BLOCKED` but was instead returning `COMPLETED`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independently of the
DROPPEDchanges in flight in the other PR, this PR adds more tests for futures, repeated partial stream reads/writes, and zero-length read/writes. Everything passes in Wasmtime with the exception of the last (rather corner) case intest/async/zero-length.wast(namedzero-write-after-cancelled-write). In this test, a zero-length read is notified by a non-zero-length write, but then that write is cancelled (successfully), and a new zero-length write is issued which in theory should returnBLOCKEDbecause there is no longer a pending read (even though the original zero-length read's notification has not yet been delivered). This is symmetric to what happens inzero-write-after-full-read(which passes on Wasmtime, and just replaces the zero-length buffer with a non-zero-length buffer) so my impression is that the zero-length case is a bug, but lmkwyt @dicej @alexcrichton.