Revisions: Remove unused list-revisions.js file - #13428
Conversation
The wp-list-revisions.js script was introduced in [12500] to hide radio buttons on the old WordPress 3.0 table-based revisions screen. That UI was replaced by the Backbone.js + jQuery UI slider interface in WordPress 3.6 ([#20564]). The script targets a #post-revisions element with left/right named radio inputs that no longer exists in the DOM. The script handle is registered in script-loader.php but has never been enqueued since the UI was replaced. Fixes #66061.
…er.php. The list-revisions script handle was registered but never enqueued anywhere in the codebase. Removes the now-unused registration as part of #66061.
Removes both concat task entries that compiled the now-deleted list-revisions.js source into wp-list-revisions.js. Part of #66061.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
SainathPoojary
changed the title
1 participant
This PR removes
list-revisions.jsand its related references, as it is no longer used in core.As noted in the ticket, the script targets a
#post-revisionsID containing radio inputs for the old WordPress 3.0 table based revisions screen. That UI was replaced in 3.6, and the ID no longer exists in the DOM. The script is also currently registered inscript-loader.phpbut never enqueued anywhere.This PR:
src/js/_enqueues/lib/list-revisions.jsfile.src/wp-includes/script-loader.php.Gruntfile.js.Trac ticket: https://core.trac.wordpress.org/ticket/66061
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.