Repository navigation
Conversation
Backend unit coveragePASS · minimum combined coverage 98.00%. Tests: 11995 passed, 0 failed, 0 skipped. Source files: 400.
Unit coverage includes every backend workspace. PostgreSQL/Redis integration tests run separately. Commit: 60104b9 · HTML, JSON, XML reports and job logs · attempt 1 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes and why?
RQ work horses repeatedly fetch and normalize the same source-tag catalog. Add an opt-in, bounded shared identity projection, with a dedicated namespace and PostgreSQL transactional revisions as the authority. Only name/slug/alias→UUID identities are cached; article/editorial decisions remain current SQL reads.
Ingestion prefetches Redis bytes and decodes them before opening its final SQL transaction. A scoped context carries the candidate and is cleared on every exit. Inside SQL, matching revisions are checked before/after reuse. Callers without prefetch use baseline SQL and perform no shared GET inside their transaction. Borrowed-Connection Sessions skip publication; explicitly Connection-bound ingestion factories skip prefetch too, because their external transaction can outlive the Session. Cold compression/publication runs after the root transaction and connection check-in; explicit rollback cancels it and an open breaker skips serialization. Cache failures do not fail an already committed delivery, while RQ deadlines propagate.
Validation
Negative and variable observations remain explicit:
Rollout notes
DEVFEED_SOURCE_TAG_SHARED_CACHE_ENABLEDremains false. Do not enable until native ARM64 concurrent-import canaries establish PostgreSQL CPU/slot and worker-memory budgets, shared hit ratio, catalog edit rate and Redis payload/connection limits. Frequent edits can erase reuse and add application publication cost. The dedicated flag restores process-local behavior without disabling public API caching. No migration, production configuration change or deployment performed.GETRANGE and bounded decompression enforce 4 MB wire/16 MB decoded/100,000-tag limits; malformed, stale, oversized and unavailable data falls back to baseline SQL. The feature never replaces current article approval/classification reads.
Ready for review