Fix scopes combined with OR combinator not working

[Copilot]

Fixes an issue where scopes combined with the :or combinator would not generate proper OR logic in SQL queries.

Problem

When using scopes with the OR combinator, the generated SQL would ignore the OR logic and apply scopes with AND semantics instead:

class Person < ActiveRecord::Base
  scope :red, -> { where(color: 'red') }
  scope :green, -> { where(color: 'green') }

  def self.ransackable_scopes(auth_object = nil)
    [:red, :green]
  end
end

# This would generate AND logic instead of OR
Person.ransack(red: true, green: true, m: :or).result.to_sql
# Before: SELECT * FROM people WHERE color = 'red' AND color = 'green'  (impossible)
# Expected: SELECT * FROM people WHERE (color = 'red') OR (color = 'green')

Root Cause

Scopes were applied immediately during search building via @context.chain_scope(), bypassing the visitor pattern that handles OR/AND combinator logic. This meant scopes were always chained with AND semantics regardless of the specified combinator.

Solution

Two-part minimal fix:

1. Defer scope application: When OR combinator is detected, don't immediately apply scopes during search building
2. OR evaluation: During query evaluation, create separate relations for each scope and combine them using ActiveRecord's .or() method

The fix handles:

• ✅ Multiple scopes with OR: Person.ransack(red: true, green: true, m: :or)
• ✅ Mixed scopes and conditions: Person.ransack(red: true, name_cont: 'John', m: :or)
• ✅ Preserves AND behavior (default): Person.ransack(red: true, green: true)
• ✅ Respects existing scope logic: false values, arity handling, etc.
• ✅ Edge cases: empty scopes, all-false scopes

Changes Made

• lib/ransack/search.rb: Modified add_scope to defer scope application when OR combinator is used
• lib/ransack/adapters/active_record/context.rb: Enhanced evaluate method to handle scope OR combinations
• spec/ransack/scope_or_combinator_spec.rb: Added comprehensive test coverage

Backward Compatibility

This change is fully backward compatible. The default AND behavior remains completely unchanged, and the fix only activates when both OR combinator and scopes are present.

Closes #[issue_number]

---

Additional instructions:

Create a PR with the provided tests

Fixes #1110

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[scarroll32]

Note

Comment from Claude (Claude Code), acting on behalf of @scarroll32.

Closing as part of clearing the PR backlog ahead of 5.0.0 (#1640).

This is one of a batch of PRs opened by the Copilot coding agent in September 2025. They have aged out: main has moved on substantially since (Rails 8.1 support, the CI matrix rework in #1667, the v5.0.0 branch consolidation in #1647), and most of these either no longer apply cleanly, no longer pass, or carry specs that don't run under the project's _spec.rb pattern.

The underlying issue stays open. Nothing is being dismissed on the merits — the bug reports behind these PRs are still valid and still wanted. What's being retired is a batch of stale machine-generated branches that cost more to salvage than to redo.

If you're affected by the underlying issue, the most useful contribution is a PR with a failing spec that reproduces it against current main — see CONTRIBUTING.md.