Skip to content

Use ROCm clang for Ghost unified-memory examples #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannybaths wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use ROCm clang for Ghost unified-memory examples #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5b13b0
Use ROCm clang for Ghost unified-memory examples
Sep 8, 2026
61a35e7
Narrow the ROCm compiler fallback to the wrapper-absent case
dannybaths Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/mpi_ghost_exchange_ver1.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,18 @@ else
module load openmpi
fi

# /etc/cray-release exists on a Cray system even when no PrgEnv module has put
# the compiler wrappers on PATH. The branch above then exports an empty CXX and
# CMake falls back to /usr/bin/c++, which does not implement
# "#pragma omp requires unified_shared_memory". Use the ROCm compilers only in
# that case, so a working wrapper or an explicit user choice is left alone.

@gcapodagAMD gcapodagAMD Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these comments

if [ -z "${CXX:-}" ] || ! command -v "${CXX}" >/dev/null 2>&1; then
if [ -x "${ROCM_PATH:-}/bin/amdclang++" ] && [ -x "${ROCM_PATH:-}/bin/amdclang" ]; then
export CXX="${ROCM_PATH}/bin/amdclang++"
export CC="${ROCM_PATH}/bin/amdclang"
fi
fi

REPO_DIR="$(dirname "$(dirname "$(readlink -fm "$0")")")"
cd ${REPO_DIR}/MPI-examples/GhostExchange/GhostExchange_ArrayAssign

Expand Down
12 changes: 12 additions & 0 deletions tests/mpi_ghost_exchange_ver2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,18 @@ else
module load openmpi
fi

# /etc/cray-release exists on a Cray system even when no PrgEnv module has put
# the compiler wrappers on PATH. The branch above then exports an empty CXX and
# CMake falls back to /usr/bin/c++, which does not implement
# "#pragma omp requires unified_shared_memory". Use the ROCm compilers only in
# that case, so a working wrapper or an explicit user choice is left alone.

@gcapodagAMD gcapodagAMD Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these all over

if [ -z "${CXX:-}" ] || ! command -v "${CXX}" >/dev/null 2>&1; then
if [ -x "${ROCM_PATH:-}/bin/amdclang++" ] && [ -x "${ROCM_PATH:-}/bin/amdclang" ]; then
export CXX="${ROCM_PATH}/bin/amdclang++"
export CC="${ROCM_PATH}/bin/amdclang"
fi
fi

export HSA_XNACK=1

if ! command -v rocprof-sys-instrument >/dev/null 2>&1; then
Expand Down
12 changes: 12 additions & 0 deletions tests/mpi_ghost_exchange_ver3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,18 @@ else
module load openmpi
fi

# /etc/cray-release exists on a Cray system even when no PrgEnv module has put
# the compiler wrappers on PATH. The branch above then exports an empty CXX and
# CMake falls back to /usr/bin/c++, which does not implement
# "#pragma omp requires unified_shared_memory". Use the ROCm compilers only in
# that case, so a working wrapper or an explicit user choice is left alone.
if [ -z "${CXX:-}" ] || ! command -v "${CXX}" >/dev/null 2>&1; then
if [ -x "${ROCM_PATH:-}/bin/amdclang++" ] && [ -x "${ROCM_PATH:-}/bin/amdclang" ]; then
export CXX="${ROCM_PATH}/bin/amdclang++"
export CC="${ROCM_PATH}/bin/amdclang"
fi
fi

XNACK_COUNT=`rocminfo | grep xnack | wc -l`
if [ ${XNACK_COUNT} -lt 1 ]; then
echo "Skip"
Expand Down
12 changes: 12 additions & 0 deletions tests/mpi_ghost_exchange_ver4.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,18 @@ else
module load openmpi
fi

# /etc/cray-release exists on a Cray system even when no PrgEnv module has put
# the compiler wrappers on PATH. The branch above then exports an empty CXX and
# CMake falls back to /usr/bin/c++, which does not implement
# "#pragma omp requires unified_shared_memory". Use the ROCm compilers only in
# that case, so a working wrapper or an explicit user choice is left alone.
if [ -z "${CXX:-}" ] || ! command -v "${CXX}" >/dev/null 2>&1; then
if [ -x "${ROCM_PATH:-}/bin/amdclang++" ] && [ -x "${ROCM_PATH:-}/bin/amdclang" ]; then
export CXX="${ROCM_PATH}/bin/amdclang++"
export CC="${ROCM_PATH}/bin/amdclang"
fi
fi

XNACK_COUNT=`rocminfo | grep xnack | wc -l`
if [ ${XNACK_COUNT} -lt 1 ]; then
echo "Skip"
Expand Down
12 changes: 12 additions & 0 deletions tests/mpi_ghost_exchange_ver5.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,18 @@ else
module load openmpi
fi

# /etc/cray-release exists on a Cray system even when no PrgEnv module has put
# the compiler wrappers on PATH. The branch above then exports an empty CXX and
# CMake falls back to /usr/bin/c++, which does not implement
# "#pragma omp requires unified_shared_memory". Use the ROCm compilers only in
# that case, so a working wrapper or an explicit user choice is left alone.
if [ -z "${CXX:-}" ] || ! command -v "${CXX}" >/dev/null 2>&1; then
if [ -x "${ROCM_PATH:-}/bin/amdclang++" ] && [ -x "${ROCM_PATH:-}/bin/amdclang" ]; then
export CXX="${ROCM_PATH}/bin/amdclang++"
export CC="${ROCM_PATH}/bin/amdclang"
fi
fi

XNACK_COUNT=`rocminfo | grep xnack | wc -l`
if [ ${XNACK_COUNT} -lt 1 ]; then
echo "Skip"
Expand Down