fix(@angular/build): miscellaneous build correctness and cache fixes - #34085
Merged
alan-agius4 merged 3 commits intoSep 11, 2026
Conversation
…ed watch files Collect referenced files from inline stylesheet contexts in addition to file contexts when gathering watch files, and catch unhandled rejections when disposing an inline bundler context.
…tension regex in polyfills Ensure sourceFileCache.loadResultCache is forwarded when creating compiler plugin options for browser polyfills, escape the file extension regex in entryFileToWorkspaceRelative, and add a missing semicolon in SSR bundle options.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements and bug fixes to the Angular build tools. Key changes include adding error handling to bundler disposal, collecting referenced files from inline contexts, fixing a regular expression to properly escape a dot, and correcting the asynchronous cache retrieval logic in BundlerContext. Additionally, an invalidation epoch mechanism was introduced to prevent caching outdated build results when invalidation occurs during an active build. Since there are no review comments, no further feedback is provided.
alan-agius4
added
action: review
clydin
approved these changes
Sep 11, 2026
…lve load cache Introduce an invalidation epoch guard to prevent caching stale esbuild results when an invalidation occurs while bundling is in-flight, and correctly await load cache checks before falling back to alternate keys.
alan-agius4
force-pushed
the
fix-build-esbuild-correctness
branch
from
September 11, 2026 15:13
8e5b7a9 to
6a0b76e
Compare
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts several general build correctness and caching fixes that were previously included in #33909, addressing review feedback from @clydin:
sourceFileCache.loadResultCacheis forwarded when creating compiler plugin options for browser polyfills, escape the file extension regex inentryFileToWorkspaceRelative, and add a missing semicolon in SSR bundle options.