Skip to content

refactor: add package.json exports to architect and schematics - #34108

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:refactor/devkit-package-exports
Sep 17, 2026
Merged

clydin merged 1 commit into
angular:mainfrom
clydin:refactor/devkit-package-exports

Conversation

@clydin

@clydin clydin commented Sep 17, 2026

Copy link
Copy Markdown
Member

Adds package.json exports fields to @angular-devkit/architect and @angular-devkit/schematics to explicitly define their public entry points and encapsulation in preparation for ESM conversion.

@angular-devkit/architect exports the root, node, testing, builders.json, and package.json. @angular-devkit/schematics exports the root, tasks, testing, tools, collection-schema.json, and package.json. Also adds the corresponding public API golden definitions for @angular-devkit/architect.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Sep 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces explicit package exports maps in the package.json files for both @angular-devkit/architect and @angular-devkit/schematics to properly expose their subpaths (such as ./node, ./testing, ./tasks, and ./tools) and configuration files. It also adds corresponding API golden files for the newly exposed architect subpaths. The feedback recommends adding ./builders/builders.json to the exports map of @angular-devkit/architect to ensure compatibility with external tools resolving the builders file directly via its declared path.

Comment thread packages/angular_devkit/architect/package.json
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 17, 2026
Adds package.json exports fields to @angular-devkit/architect and @angular-devkit/schematics to explicitly define their public entry points and encapsulation in preparation for ESM conversion.

@angular-devkit/architect exports the root, node, testing, builders.json, and package.json.
@angular-devkit/schematics exports the root, tasks, testing, tools, collection-schema.json, and package.json.
Also adds the corresponding public API golden definitions for @angular-devkit/architect.
@clydin
clydin force-pushed the refactor/devkit-package-exports branch from aac154c to 1288984 Compare September 17, 2026 16:25
@clydin
clydin merged commit 2b59d84 into angular:main Sep 17, 2026
66 of 67 checks passed
@clydin

clydin commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the refactor/devkit-package-exports branch September 17, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants