Skip to content

build: remove @angular-devkit/schematics devDependency from tests - #34708

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:remove-tests-schematics-dep
Nov 13, 2026
Merged

build: remove @angular-devkit/schematics devDependency from tests#34708
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:remove-tests-schematics-dep

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

tests/package.json declares @angular-devkit/schematics in devDependencies solely so //tests/angular_devkit/schematics/tools/file-system-engine-host:file_system_engine_host_test_lib can reference //tests:node_modules/@angular-devkit/schematics.

Issue Number: N/A

What is the new behavior?

@angular-devkit/schematics is removed from tests/package.json (and pnpm-lock.yaml), and file_system_engine_host_test_lib depends directly on //packages/angular_devkit/schematics.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 12, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Bazel build dependencies for the file system engine host tests to reference the local '@angular-devkit/schematics' package directly from '//packages/angular_devkit/schematics' instead of referencing it via 'node_modules' in the tests directory. Consequently, the '@angular-devkit/schematics' dependency has been removed from 'tests/package.json'. There are no review comments, and I have no feedback to provide.

@alan-agius4 alan-agius4 reopened this Nov 13, 2026
@alan-agius4
build: remove @angular-devkit/schematics devDependency from tests
e1e3c3e 
Update file_system_engine_host_test_lib to depend directly on
//packages/angular_devkit/schematics instead of linking the workspace
package through tests/package.json.
@alan-agius4
alan-agius4 force-pushed the remove-tests-schematics-dep branch from fb66270 to e1e3c3e Compare November 13, 2026 08:06
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 13, 2026
@alan-agius4
alan-agius4 requested a review from clydin November 13, 2026 09:20
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 13, 2026
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 13, 2026
@ngbot

ngbot Bot commented Nov 13, 2026

Copy link
Copy Markdown

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alan-agius4
alan-agius4 merged commit d3295e1 into angular:main Nov 13, 2026
43 checks passed
@alan-agius4
alan-agius4 deleted the remove-tests-schematics-dep branch November 13, 2026 12:48
@alan-agius4

alan-agius4 commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clydin clydin clydin approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-agius4 @clydin