Repository navigation
test: verify snapshot updates in the Vitest snapshot e2e test - #34710
Merged
Merged
Conversation
clydin
force-pushed
the
vitest-snapshot-update-e2e
branch
from
November 13, 2026 14:23
cc121c5 to
9779c78
Compare
Extends the Vitest snapshot e2e test to cover updating existing snapshots after a mismatch. Vitest reads the `UPDATE_SNAPSHOT` environment variable directly, which is currently the way to request an update through `ng test` without a Vitest configuration file since the builder does not forward the `--update` flag. The test now verifies that both the file snapshot and the inline snapshot are rewritten on disk with the new output and that a subsequent run passes without any further snapshot changes.
clydin
force-pushed
the
vitest-snapshot-update-e2e
branch
from
November 13, 2026 14:51
9779c78 to
c30c5cb
Compare
clydin
marked this pull request as ready for review
November 13, 2026 15:04
clydin
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Vitest snapshot end-to-end test in tests/e2e/tests/vitest/snapshot.ts. It modifies the test to break snapshots using a prefix-preserving string so that substring assertions still pass, and then adds assertions to verify that snapshots can be successfully updated using the UPDATE_SNAPSHOT environment variable. Finally, it ensures that subsequent test runs pass without further modifying the snapshots. There are no review comments, so I have no feedback to provide.
alan-agius4
approved these changes
Nov 13, 2026
alan-agius4
added
action: merge
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the Vitest snapshot e2e test to cover updating existing snapshots after a mismatch. Vitest reads the
UPDATE_SNAPSHOTenvironment variable directly, which is currently the way to request an update throughng testwithout a Vitest configuration file since the builder does not forward the--updateflag.The test now verifies that both the file snapshot and the inline snapshot are rewritten on disk with the new output and that a subsequent run passes without any further snapshot changes.