Repository navigation
Conversation
Replace downloads from inside Robolectric workers with a shared directory of the exact API 34 and 35 instrumented jars. Resolve each version separately so Gradle caches both; leave modules without Robolectric alone. Verified on the Linux QA VM: Gradle --offline force-ran ComposerAutocompleteTests, AppWideWorkTests, LabVoiceKeysTests and SharedImageEncoderTests (19 passing) with an empty Maven repository and an unreachable Robolectric download URL.
Keep the iOS test names, correctness checks and original local limits. Skip only the elapsed-time assertions on shared CI runners, where unrelated load can exceed a budget. Track CI as a Gradle test input so local runs cannot reuse CI results. Verified on the Linux QA VM: vm.sh check passed for all modules with local budgets enabled; AgentFileLoadingTests also ran all 10 cases with CI=true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed randomly today and blocked merges and release cuts (CI-01). Two causes:
android-all-instrumentedjars from Maven Central at test time; the JUnit XML from main run 42653023505 and PR fix(build): install on Android 14; microphone and location hardware optional #16 run 42663258902 shows HTTP 429 fromrepo1.maven.orgfor the API 35 jar. Gradle now resolves the two SDK jars the tests use (API 3414-robolectric-10818077-i7, API 3515-robolectric-13954326-i7, pinned in the version catalog to match Robolectric'sDefaultSdkProvider) into a build dir, so the existing Gradle cache covers them, and Robolectric runs withrobolectric.offline=truefrom that dir. A test asking for another SDK now fails fast instead of downloading.elapsedMs < 50inAgentFileTests) failed on busy runners. On CI (CIset) the timing limits aren't enforced; test names, correctness asserts, simulated-clock checks and polling timeouts are unchanged, and local runs keep the original budgets.CIis a declared test input so results aren't reused across the two.Verified on the QA VM: full
scripts/check.shpasses (6m 29s); the previously failing classes (ComposerAutocompleteTests, AppWideWorkTests, LabVoiceKeysTests, LiveHapticsFrameworkTests, plus an API 34 test) pass with Gradle--offline, an empty Maven repo and an unreachable download URL.