Skip to content

fix(media): put the markup editor and catch up controls in a top app bar - #178

Merged
Tarquinen merged 1 commit into
devfrom
top-bar-buttons
Nov 19, 2026
Merged

Tarquinen merged 1 commit into
devfrom
top-bar-buttons

Conversation

@Tarquinen

Copy link
Copy Markdown
Member

The image markup editor's ×, undo and ✓, and Catch Up's back and Undo, were floating rounded-square chips. They now sit in a Material top app bar, as the QR scanner and file viewer already do. In the editor, × is the navigation icon, the bar has a "Draw on Image" title, undo is a bare icon action and confirm is an "Add" text action (TalkBack still says "Add to Prompt"). In Catch Up, back is a bare arrow, the count is the bar's title and Undo is a text action.

Markup editor before and after, over a white and a dark image

Catch Up before and after, light and dark

Taps, enablement, haptics, the discard prompt on × and system Back, and Catch Up's Back all behave as before. No motion is added. Checked on the emulator with session-lab: landscape, and German, Bengali and Romanian at font scale 2.0.

The image markup editor's ×, undo and ✓ and Catch Up's back and Undo were
floating rounded-square chips. They now sit in an OpenCodeTopBar, as the
QR scanner and file viewer already do: the editor gets × as navigation, a
"Draw on Image" title, undo as a bare icon action and an "Add" text action
(still announced as "Add to Prompt"), dark over the black canvas; Catch Up
gets a bare back arrow, the count as a start-aligned title and Undo as a
text action. The local CatchUpUndoButton is gone. Behaviour, enablement,
haptics and back handling are unchanged. No motion added.

Verified on the emulator with session-lab: editor over white and black
images, empty and after strokes, undo, × and system Back both ask to
discard, Add returns the drawn image to the composer, landscape, German at
font scale 2.0; Catch Up light and dark with Undo enabled and working,
Bengali and Romanian at font scale 2.0. vm.sh check :feature:media
:feature:drawer passed.
@Tarquinen
Tarquinen merged commit 4fd1a59 into dev Nov 19, 2026
3 checks passed
@Tarquinen
Tarquinen deleted the top-bar-buttons branch November 19, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant