Repository navigation
fix(media): put the markup editor and catch up controls in a top app bar - #178
Merged
Merged
Conversation
The image markup editor's ×, undo and ✓ and Catch Up's back and Undo were floating rounded-square chips. They now sit in an OpenCodeTopBar, as the QR scanner and file viewer already do: the editor gets × as navigation, a "Draw on Image" title, undo as a bare icon action and an "Add" text action (still announced as "Add to Prompt"), dark over the black canvas; Catch Up gets a bare back arrow, the count as a start-aligned title and Undo as a text action. The local CatchUpUndoButton is gone. Behaviour, enablement, haptics and back handling are unchanged. No motion added. Verified on the emulator with session-lab: editor over white and black images, empty and after strokes, undo, × and system Back both ask to discard, Add returns the drawn image to the composer, landscape, German at font scale 2.0; Catch Up light and dark with Undo enabled and working, Bengali and Romanian at font scale 2.0. vm.sh check :feature:media :feature:drawer passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image markup editor's ×, undo and ✓, and Catch Up's back and Undo, were floating rounded-square chips. They now sit in a Material top app bar, as the QR scanner and file viewer already do. In the editor, × is the navigation icon, the bar has a "Draw on Image" title, undo is a bare icon action and confirm is an "Add" text action (TalkBack still says "Add to Prompt"). In Catch Up, back is a bare arrow, the count is the bar's title and Undo is a text action.
Taps, enablement, haptics, the discard prompt on × and system Back, and Catch Up's Back all behave as before. No motion is added. Checked on the emulator with session-lab: landscape, and German, Bengali and Romanian at font scale 2.0.