Repository navigation
CI: release only green commits, don't re-check release tags - #22
Merged
Merged
Conversation
The scheduled release tagged main without looking at its CI, so a red main still got a GitHub release (whose tag build then failed before Play). It now skips unless the commit's push run of android.yml on main succeeded; a run still in progress waits for the next release time. Release tags reran scripts/check.sh on a commit main had already checked. The tag run now skips the check (and the debug APK artifact) when main already passed that exact commit, and goes straight to the signed bundle. A tag on a commit main never passed (e.g. cut by hand) still runs the check. PR and post-merge checks on main are unchanged: the main run writes the Gradle cache PRs read, and catches PRs that break only in combination. Verified: both workflows parse as YAML; the gh run list query returns "success" for 993afa0 and empty for an unknown SHA (both paths handled). The tag path can't run without cutting a release.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's push run ofandroid.ymlpassed for that commit. Before, a brokenmainstill got a GitHub release with no Play build behind it. A run still in progress just waits for the next release time.mainalready passed the exact commit, the tag run skipsscripts/check.shand goes straight to the signed bundle, so releases reach Play about 5 minutes sooner. Tags on commitsmainnever passed (e.g. cut by hand) still run the full check.PR checks and the post-merge check on
mainare unchanged. Themainrun is what fills the Gradle cache that PRs read, and it catches PRs that only break in combination.The tag path can't be exercised without cutting a release, so the first scheduled release after merging is the real test.