Skip to content

feat(session): open Session Media from the Session sheet - #221

Merged
Tarquinen merged 3 commits into
devfrom
session-media-sheet-row
Nov 21, 2026
Merged

Tarquinen merged 3 commits into
devfrom
session-media-sheet-row

Conversation

@Tarquinen

@Tarquinen Tarquinen commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

The Session sheet now has a Media · Files and Links row under the details card. Tapping it opens Session Media while the sheet slides down. Before this, Session Media was only in the ⋮ menu. Ports iOS #353 (56a3e7de).

Before (left) and after (right):

Session sheet, light
Session sheet, dark

Tap → Session Media (happens a few times a day at most; the sheet keeps Material's slide and the page keeps its usual entrance):

sheet-media-handoff.mp4

Verified

  • Full scripts/check.sh on the VM.
  • Emulator with session-lab, stepped frame by frame at 1× and 5× animator scale: the sheet slides down as the page fades in, with no cut to the bare transcript.
  • With the composer focused before opening the sheet, the keyboard stays hidden through the hand-off.
  • The row shows correctly in light and dark.

The Session sheet gets a Media row ("Files and Links", with a chevron) under the
details card, as on iOS (#353, 56a3e7de). Tapping it closes the sheet and opens
the Session Media page; before, Session Media could only be reached from the ⋮ menu.
SessionMediaTapped now also clears activePicker, so the sheet doesn't stay over the page.

Verified: scripts/check.sh :feature:session on the VM; the new reducer test fails
without the activePicker change; on the emulator with session-lab the row shows in
light and dark, and a tap closes the sheet and opens Session Media.
Review follow-up. Tapping Media used to clear activePicker in the same
frame, so the sheet and its scrim vanished at once (a hard cut to the
bare transcript before the page faded in). Now the row sends
SessionMediaTapped right away, so the page starts its entrance under the
sheet, and the sheet slides down with Material's own motion and is
dismissed when the slide ends. The reducer is back to dev's (it no longer
clears activePicker), so the reducer test that asserted it is gone.

Also: "Files and Links" ellipsizes like the Model row, the prewarm
composes MediaCard, and the parity row for SessionSheetView.swift notes
56a3e7de.

Verified: full scripts/check.sh on the VM. On the emulator, frame by
frame at 1x and 5x animator scale: the sheet slides down and the page
fades in; there is no cut. With the composer focused before opening the
sheet, the keyboard stays hidden through the hand-off (dumpsys
mInputShown=false throughout).
@Tarquinen
Tarquinen enabled auto-merge (squash) November 21, 2026 01:06
@Tarquinen
Tarquinen merged commit 9b26e59 into dev Nov 21, 2026
2 checks passed
@Tarquinen
Tarquinen deleted the session-media-sheet-row branch November 21, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant