Repository navigation
feat(session): open Session Media from the Session sheet - #221
Merged
Merged
Conversation
The Session sheet gets a Media row ("Files and Links", with a chevron) under the
details card, as on iOS (#353, 56a3e7de). Tapping it closes the sheet and opens
the Session Media page; before, Session Media could only be reached from the ⋮ menu.
SessionMediaTapped now also clears activePicker, so the sheet doesn't stay over the page.
Verified: scripts/check.sh :feature:session on the VM; the new reducer test fails
without the activePicker change; on the emulator with session-lab the row shows in
light and dark, and a tap closes the sheet and opens Session Media.
Review follow-up. Tapping Media used to clear activePicker in the same frame, so the sheet and its scrim vanished at once (a hard cut to the bare transcript before the page faded in). Now the row sends SessionMediaTapped right away, so the page starts its entrance under the sheet, and the sheet slides down with Material's own motion and is dismissed when the slide ends. The reducer is back to dev's (it no longer clears activePicker), so the reducer test that asserted it is gone. Also: "Files and Links" ellipsizes like the Model row, the prewarm composes MediaCard, and the parity row for SessionSheetView.swift notes 56a3e7de. Verified: full scripts/check.sh on the VM. On the emulator, frame by frame at 1x and 5x animator scale: the sheet slides down and the page fades in; there is no cut. With the composer focused before opening the sheet, the keyboard stays hidden through the hand-off (dumpsys mInputShown=false throughout).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Session sheet now has a Media · Files and Links row under the details card. Tapping it opens Session Media while the sheet slides down. Before this, Session Media was only in the ⋮ menu. Ports iOS #353 (56a3e7de).
Before (left) and after (right):
Tap → Session Media (happens a few times a day at most; the sheet keeps Material's slide and the page keeps its usual entrance):
sheet-media-handoff.mp4
Verified
scripts/check.shon the VM.